Skip to content

fix(search): dock the search header after results arrive - #7948

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-incomplete-header
Sep 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-incomplete-header

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the organization Search header centered until results arrive, then keep it docked through source and date refinements without replacing the input or filters.
  • Label empty partial searches as timeouts and omit the separate indexing note on partial responses.

Type of Change

  • Bug fix

Testing

  • 36 focused tests passed, including filtered request payloads, stable controls and focus, empty/error/timeout recovery, cancellation, and query/access-scope isolation.
  • Checked the initial loading and empty layouts in the local app.
  • App type-check, lint, 46 repository audits, block registry validation, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 17, 2026 9:52pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the new docking lifecycle and partial-search messaging are consistent with the search state and are covered by focused transition tests.

Summary

This PR keeps organization search centered through initial loading and non-result outcomes, then docks the same input and filters once results have appeared.

  • Preserves the docked state through source and date refinements, including empty, timeout, and error outcomes.
  • Retains input drafts, focus, and filter component identity during the initial docking transition.
  • Labels empty partial retrievals as timeouts and removes the separate indexing note from partial responses.
  • Expands transition and status coverage for the updated behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Query submitted] --> B[Centered search and loading state]
  B -->|Results arrive| C[Docked header and results]
  B -->|Empty, error, or timeout| B
  C --> D[Source or date refinement]
  D -->|Loading or any outcome| C
  C -->|New query| B
Loading

Reviews (1) · Last reviewed commit: "fix(search): dock the search header afte..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit cbdb864 into staging Sep 17, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-incomplete-header branch September 17, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant