fix(ci): stop the CodeQL cron cancelling the main merge scan - #7933
Merged
Merged
Conversation
The workflow-level `cancel-in-progress: true` applied to every trigger, but push and schedule both resolve to `refs/heads/main` and therefore share the `codeql-refs/heads/main` concurrency group. A merge landing shortly before the daily cron had its scan cancelled mid-extraction, leaving main with a red status rollup for a commit the cron then scanned clean. Scoping the cancel to `pull_request` keeps the superseding behavior where it belongs -- each PR is its own group via `refs/pull/N/merge` -- and lets non-PR events queue behind an in-progress run instead of killing it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel-in-progresstopull_requestinstead of every triggerpushandscheduleboth resolve torefs/heads/main, so they shared thecodeql-refs/heads/mainconcurrency group — a merge landing in the ~2 minute window before the daily cron got its scan cancelled mid-extraction, and main showed a red status rollup for a commit the cron had in fact scanned cleanrefs/pull/N/merge, which is where 49 of the 50 cancellations in the last 300 runs happenedThis restores what the workflow originally shipped with; the blanket
truecame in alongside the weekly-cron change and the collision window widened 7x when the cron went back to daily.Type of Change
Testing
actionlintclean and the YAML parses with the expression intact. No generator or audit incheck:auditsreads.github/workflows/**, andcheck:cron-paritycovers the app crontab (docker/crontab,helm/sim/values.yaml), not Actions schedules.Checklist