Skip to content

fix(integ): bound credential scans and classify disabled TTL - #7860

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
fix/integ-slow-resource-queries
Sep 15, 2026
Merged

TheodoreSpeaks merged 2 commits into
stagingfrom
fix/integ-slow-resource-queries

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Credential deletion exceeded the integ client's 30-second timeout while the paused-execution reference query reached a 46-second p99. Materialize workspace-scoped rows before searching JSON across blocks, deployments, paused executions, and checkpoints, preserving archived-workflow cleanup.

Also give disabled TTL column creation a stable TABLE_ROW_TTL_DISABLED detail code so the integration probe can tolerate error wording changes without accepting unrelated 400s. Deploy this app change before the companion infra check.

Related integration update: https://github.com/simstudioai/infra/pull/361

PostgreSQL CI also exposed a cross-file DDL deadlock: one suite replaced OAuth triggers while another deleted a user. Run the shared-schema suites sequentially; their internal concurrency tests remain concurrent.

Testing

  • App type-check and API validation audit passed.
  • 48 credential cleanup/orchestration/webhook tests and 17 TTL/error-policy tests passed.
  • Synthetic PostgreSQL validation confirmed identical results, workspace isolation, and archived-workflow coverage. Under the same alternative join plan, JSON inspection dropped from 2,003 rows to the target workspace's 3 rows.
  • No schema migration or new retry behavior.

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 15, 2026 8:56pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified.

Summary

Bounds credential-reference JSON inspection to the target workspace and adds stable classification for disabled table-row TTL.

  • Uses a shared MATERIALIZED CTE for workflow blocks, deployment versions, paused executions, and checkpoints while preserving archived-workflow cleanup.
  • Returns TABLE_ROW_TTL_DISABLED in v2 error details without relying on message wording or classifying unrelated validation errors as TTL-disabled.
  • Adds regression coverage for SQL structure, reference updates, failure propagation, and direct/cause-wrapped TTL errors.
  • No actionable issues were identified. Tests were inspected but not executed during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Credential cleanup] --> B[Each of four snapshot sources]
  B --> C[Join workflows and filter workspace]
  C --> D[Materialized workspace rows]
  D --> E[JSON-to-text credential search]
  E --> F[Clear exact credential references]
  F --> G[Update changed rows by primary key]
Loading

Reviews (1) · Last reviewed commit: "fix(integ): bound credential scans and c..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 3856d9e into staging Sep 15, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/integ-slow-resource-queries branch September 16, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant