fix(agent): authorize workspace attachments through execution delegation - #7859
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
428 tests across 14 files passed, including 12 PostgreSQL/storage/Agent/provider-SDK harness scenarios. The harness verifies persisted references and next-turn byte replay for OpenAI and Anthropic with streaming on/off; provider HTTP responses are synthetic. Negative controls cover missing delegation, wrong workspace, completed executions, mismatched deployments, and deleted files before provider HTTP. Registry-wide attachment strategies and OpenAI/Gemini large uploads are covered. An additional 15 real-authorization cases confirm unprefixed keys remain denied for standalone, session, and system callers. App/auth type-check, full lint, strict API validation, and all 46 audits passed.
Checklist