Skip to content

fix(workflows): preserve file inputs in workflow testing - #7857

Merged
icecrasher321 merged 2 commits into
stagingfrom
codex/workflow-file-inputs
Sep 15, 2026
Merged

icecrasher321 merged 2 commits into
stagingfrom
codex/workflow-file-inputs

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Share workflow input schemas between discovery and run validation so file[] fields accept uploaded file objects and preserve their metadata.
  • Generate valid file input samples and remove the obsolete files/base64 schema and duplicate type mappings.
  • Require canonical file storage keys in both JSON Schema and runtime validation, normalize editor file defaults, and reject reserved input names.
  • Cover file input validation, Start-block handling, and indexed sandbox path references in Shell, Python, and JavaScript.

Type of Change

  • Bug fix

Testing

  • 410 tests across 12 workflow, MCP, Copilot, and Function execution suites passed.
  • Sim type-check, repository lint, all 46 repository audits, block registry audit, and docs manifest check.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 7:32pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previous schema-contract issue is fully fixed and no actionable regression remains.

Summary

This PR unifies workflow input discovery and runtime validation around a shared schema, preserving canonical uploaded-file metadata through workflow testing.

  • Requires complete, keyed file references in both MCP JSON Schema and runtime validation.
  • Normalizes valid editor file defaults into executable mock payloads.
  • Rejects reserved input names and unsupported input types explicitly.
  • Adds regression coverage for file validation, Start normalization, and sandbox path references.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Format[Workflow input format] --> Shared[Shared Zod input shape]
  Shared --> Discovery[MCP JSON Schema]
  Shared --> Validation[Trigger input validation]
  Format --> Sample[Normalized mock payload]
  Sample --> Validation
  Validation --> Start[Start-block normalization]
  Start --> Resolver[Variable resolver]
  Resolver --> Sandbox[Sandbox file mounts]
Loading

Reviews (2) · Last reviewed commit: "fix(workflows): align advertised file va..."

Comment thread apps/sim/lib/workflows/input-schema.ts Outdated
Comment thread apps/sim/lib/workflows/input-schema.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/workflows/input-schema.ts
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit ae4981e into staging Sep 15, 2026
33 of 34 checks passed
@icecrasher321
icecrasher321 deleted the codex/workflow-file-inputs branch September 15, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant