Skip to content

improvement(desktop): remove per-task website approval prompts - #7837

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/remove-browser-site-prompts
Sep 15, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/remove-browser-site-prompts

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove per-task website approval prompts from desktop browser links, redirects, and restored pages.
  • Delete the origin-grant cache, pending prompt state, timers, and support handshake. Preserve URL/DNS checks and microphone/camera consent.
  • Keep the legacy bridge contract and renderer fallback for installed older shells. The change takes effect after a desktop upgrade; the new shell never emits site requests.

Type of Change

  • Improvement

Testing

  • 1,601 desktop unit tests and all 26 workspace type checks passed.
  • Five Electron browser tests passed, including a link followed by a cross-origin redirect without a website prompt.
  • Cleanup, lint, all 46 repository audits (including strict API validation), and docs manifest checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 1:50am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported restore-timeout issue is resolved and no new actionable failure was established.

Summary

The PR removes per-task website approval prompts from the desktop agent browser while preserving URL/DNS restrictions, media consent, and compatibility with older installed shells. It also corrects foreground restore timing raised in the previous review.

  • Removes site-origin grants, pending prompt state, timers, native prompt fallback, and renderer support handshakes.
  • Allows checked links, redirects, popups, and restored pages to navigate without website prompts.
  • Retains private and reserved network blocking for top-level and subframe navigation.
  • Preserves legacy bridge types and retired action handling for mixed shell/renderer versions.
  • Resets a promoted background restore’s deadline from promotion time and prevents repeated promotions from extending it again.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Request[Desktop browser navigation] --> Scheme{HTTP or HTTPS?}
    Scheme -->|No| Block[Block navigation]
    Scheme -->|Yes| Guard[DNS-aware URL guard]
    Guard -->|Private, reserved, or unresolved| Block
    Guard -->|Public or allowed loopback| Load[Load without website prompt]
    Load --> Media{Camera or microphone requested?}
    Media -->|Yes| Consent[Keep document-scoped media consent]
    Media -->|No| Page[Continue page load]
    Consent --> Page
Loading

Reviews (2) · Last reviewed commit: "fix(desktop): preserve the foreground re..."

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit fb92772 into staging Sep 15, 2026
37 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/remove-browser-site-prompts branch September 15, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant