Skip to content

improvement(editor): render tool permission mode and retry fields with standard sub-block inputs - #7834

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/tool-input-settings-subblocks
Sep 15, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/tool-input-settings-subblocks

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Tool Permission Mode selector uses the same Combobox and label/toggle row as other sub-block dropdowns instead of ChipCombobox
  • Block retry Max tries / Wait between tries use ShortInput instead of ChipInput, so they match every other sub-block field
  • Retry fields pass a new allowReferences={false} option to ShortInput (threaded through SubBlockInputController into useSubBlockInput, default true), so the < / {{ reference pickers never open on values that can't hold references; they still commit on blur and clamp through the executor's normalizers

Type of Change

  • Improvement

Testing

Type-check, lint, check:audits, and the retry-settings + tool-input suites pass; added tests for commit-on-blur normalization and the disabled reference pickers

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 1:15am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues identified.

Summary

This PR aligns workflow-editor permission and retry controls with standard sub-block inputs.

  • Replaces the tool permission chip selector with the editor’s standard Combobox.
  • Renders retry values through ShortInput and commits shared normalization on blur.
  • Adds an allowReferences option so numeric retry fields cannot display tag or environment-variable pickers.
  • Updates retry tests for blur normalization and disabled reference pickers.

Reviews (2) · Last reviewed commit: "fix(editor): turn off reference pickers ..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 merged commit 2e08162 into staging Sep 15, 2026
32 of 33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/tool-input-settings-subblocks branch September 15, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant