improvement(search): speed up organization integration and source queries - #7830
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knowledgeReadAccessBatches) now starts from the sources a GitHub/Confluence grant could authorize and stops at each source's first candidate document, instead ofDISTINCT-scanning every document in the owner with the access predicate evaluated twice per rowaccess/live-sources.ts), shared by the grant resolvers and discovery, so discovery can never skip an authorizable source.KnowledgeAccessProvider.hasLiveSourceReadersbecomesliveSourceConnectorConditionviewerDocumentCountis replaced byhasViewerDocuments: exact per-viewer counts are O(visible documents) no matter how they're indexed. The member status reads "Ready to search" instead of "N searchable documents"doc_connector_processing_status_idxfor the failed/pending/processing probes behind the source status, progress and admin overview reads (concurrent build, migration 0345)searchableDocumentscountType of Change
Testing
bun scripts/test-knowledge-acls.tsreal Postgres integration suite (44 files, 374 tests) passes, including the GitHub live-grant, overview, pagination and progress suites.predicate.postgres.test.tsfails the same way on staging: its hand-built schema lacksaccess_rewrite_pending, and CI doesn't run itcheck:audits,check:api-validation:strictandcheck:migrationsall passChecklist