You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bundle shared EMCN components for desktop server settings, offline pages, and application dialogs. Use title-only headers and size compact dialogs to their content so the server picker does not scroll.
Replace native terminal confirmations and align browser, workspace, and OAuth error screens with the shared components.
Keep isolated preload permissions, safe keyboard defaults, and recovery when a bundled renderer fails. Preserve the synchronous OS unload decision required by Electron.
Type of Change
Bug fix
Testing
All eight cleanup passes; repository lint, 46 audits (including API validation), docs manifest, and all 26 workspace type-checks passed.
1,614 desktop tests, 234 shared EMCN tests, 4 terminal confirmation tests, and 8 Electron smoke tests passed.
All 3 packaged smoke tests passed on arm64 with production fuses. Local packaging uses the PNG icon because Icon Composer requires Xcode 26; CI validates the standard universal package.
The PR appears safe to merge; no outstanding correctness, security, or repository-rule violations were identified.
Summary
This PR unifies desktop dialogs, server settings, offline recovery surfaces, and related web error states around shared EMCN components.
Bundles isolated React renderers and shared styling for desktop shell pages.
Replaces native asynchronous confirmations with secured app-owned dialog windows while retaining an OS fallback.
Adds content-based sizing, renderer-failure recovery, permission restrictions, and sender validation.
Makes terminal-close confirmation asynchronous and revalidates the captured terminal before closing it.
Expands unit, smoke, and packaged-build coverage for the new flows.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Desktop main process] --> B[showShellDialog]
B --> C[Isolated BrowserWindow]
C --> D[sim-shell dialog page]
D --> E[Bundled EMCN renderer]
E -->|validated IPC response| B
E -->|content height| F[Clamped window sizing]
C -->|renderer or load failure| G[Native OS dialog fallback]
B --> H[Calling workflow]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Summary
Type of Change
Testing
Checklist