feat(design): add design conformance checks - #7827
BillLeoutsakosvl346 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| @@ -0,0 +1,418 @@ | |||
| /* biome-ignore-all lint/suspicious/noTemplateCurlyInString: Fixtures contain literal proposed JavaScript templates. */ | |||
There was a problem hiding this comment.
Non-TSDoc comments violate policy
This module-level block comment violates the repository directive that documentation comments use TSDoc and that non-TSDoc comments are not introduced. The same pattern appears at the start of scripts/check-design-conformance-composition.test.ts and scripts/check-design-conformance-refactors.test.ts. Use a compliant suppression form or restructure the fixtures to avoid the file-level suppression. This repository requirement must be satisfied before merging.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Both findings are fixed in the latest commit: unchecked diagnostics now identify files and reasons in the check log and CI summary without becoming design violations, and all four fixture suppression comments use TSDoc form. Added regressions for skipped sources, output escaping and summary limits; all 569 script tests and 46 repository audits pass. |
Summary
bun run check:design --base origin/staging --head HEADto check committed changes against central EMCN components, tokens, recipes and artwork ownership. Approved building blocks remain free to combine; new violations and central-system changes notify.design-conformance/1.3.0with root dependencies, script tests, lint, type checking and CI. Unchecked files and reasons appear in the check log and an expandable CI summary. Both finding types launch as warnings; missing revisions and other operational failures fail CI. PRs use immutable base/head SHAs, and pushes cover all pushed commits./shipand/babysit. Keep the legacy policies and maintainer replay commands; historical datasets and reports remain outside the repository.Type of Change
Testing
Checklist