Conversation
Restore the two-choice icon switch with smaller geometry and consistent label-row spacing. Use it for canonical subblocks, Start file inputs, boolean assignments, and knowledge connector fields. Keep connector radio controls outside field labels and preserve disabled and selected-state behavior.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
10 tasks
The old toggle buttons set the title row height (20px in the editor, 18px in the connector modal). The switch only occupies 14px, so Value rows in the Start block Files input and Variables block, and connector titles with a mode switch, collapsed to the label height. Give those rows the same minimum height the field header already uses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
j15z
marked this pull request as ready for review
September 15, 2026 02:59
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@j15z I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the ⇄ toggle button with a two-option switch wherever an input can flip between two modes. The old button only hinted at the current mode through its tint. The switch shows both modes side by side with the active one selected, so it's clear which mode a field is in and the other mode is one click away.
The switch is a new emcn component,
IconSwitch: two 16px icon squares in a small frame, built on native radio buttons so arrow keys move between options, with each option's name shown as a tooltip.Where it changed:
CanonicalModeToggle.ChipModalFieldtitleAdornmentslot outside the<label>, so clicking the field title doesn't change the mode, and it is disabled while the connector is being saved.Type of Change
Testing
apps/simandpackages/emcntype checks pass.IconSwitch,ChipModal, the connector config fields, the field header, subblocks, and Start file inputs.improvement/editor-deploy-experience(087a21d); after is this branch (09cc11a).Reviewers: please check the switch's alignment in the block field header, where it shares the row with Copy, Generate and link actions.
Checklist
Screenshots/Videos
Selector-or-ID fields on blocks (Slack Channel)
Agent block tool fields (Jira Account and Project)
Start block Files input
Variables block boolean value
Knowledge base connector field (Gmail Labels)
🤖 Generated with Claude Code