Skip to content

fix(workflows): preserve durable execution across repeated human pauses - #7798

Open
mzxchandra wants to merge 2 commits into
stagingfrom
fix/hitl-repeat-review
Open

fix(workflows): preserve durable execution across repeated human pauses#7798
mzxchandra wants to merge 2 commits into
stagingfrom
fix/hitl-repeat-review

Conversation

@mzxchandra

@mzxchandra mzxchandra commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep repeated human-review pauses attached to the original durable execution so subsequent submissions remain resumable.
  • Preserve the existing pause merge/recount behavior to avoid completing a newly opened pause prematurely.

Type of Change

  • Bug fix

Testing

  • Local browser: Run-button start and two review submissions completed on one durable execution. Three rounds with partial/omitted answers and a page reload also passed; the approved file appeared only after the final answer.
  • Original-code negative control reproduced failure on the second browser submission; the corrected version completed.
  • Local API and PostgreSQL: three rounds, single pause, duplicate submission rejection, cancellation followed by a late submission, and partial/omitted answers with native file promotion gating passed.
  • 94 executor tests passed, including regressions for durable identity and counting each answered pause once.
  • Ship generators, repository lint, block-registry audit, all 46 audits, docs-manifest check, and all-workspace type checking passed on the synced staging base.
  • CI passed: application build, lint/test job, both test shards, and both PostgreSQL integration jobs.
  • Hosted verification remains pending deployment; existing stranded executions require recovery.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced

@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 13, 2026 2:35am UTC

Request Review

@mzxchandra
mzxchandra changed the base branch from main to staging September 13, 2026 01:57
@mzxchandra

Copy link
Copy Markdown
Contributor Author

@greptile review

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding or newly introduced actionable issues identified.

Summary

  • Uses the parent execution ID in newly created resume snapshots.
  • Retains existing pause merging, settlement, and recount behavior.
  • Adds regression coverage for durable identity and repeated-pause counting.

Diagram

sequenceDiagram
    participant U as User
    participant P as PauseResumeManager
    participant E as Durable execution
    participant S as Pause snapshot
    U->>P: Submit first human-review response
    P->>E: Resume durable execution
    E-->>P: Pause again
    P->>S: Persist snapshot with parent execution ID
    U->>P: Submit next response
    P->>E: Resume same durable execution
Loading

Reviews (2) · Last reviewed commit: "fix(workflows): count repeated review co..."

@mzxchandra
mzxchandra marked this pull request as ready for review September 13, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant