You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add Administrator token and Non-admin token tabs to GitLab setup and settings, with CSV templates, inline validation, saved-file replacement, and PAT rotation.
Store private permission snapshots and effective grants in generic connector-owned tables. Apply replacements atomically with revision checks and immediate read-time revocation; block reads while a changed source's ACLs are rebuilt.
Exclude confidential issues and internal comments from the CSV path, preserve administrator permission mirroring, and document both setup flows with browser screenshots.
Roll out the additive migration first, then compatible Trigger workers, then the application. No new feature flag.
Type of Change
New feature
Documentation
Testing
779 relevant unit and organization UI tests passed.
Live GitLab CE regression: 9/9 passed, including administrator parity, regular KB and organization Search CSV setup, encrypted credentials, ingestion, every protected read surface, replacements, concurrent saves, and interrupted ACL changes.
Licensed GitLab 19.2.5 Auditor CSV flows: 2/2 passed with a read_api token and a custom admin role containing only read_admin_users.
Browser-tested organization setup, keyboard navigation, templates, malformed uploads, saved-file replacement, and denied/newly granted Search users. Membership replacement made no embedding calls. Regular KB setup and replacement were also exercised in the browser.
Real PostgreSQL permission-store tests passed, including rollback, owner isolation, concurrent replacements, and a 100,000-grant indexed lookup. CSV size/row limits and the request ceiling are covered.
TypeScript, lint, all 46 repository audits, API validation, generated artifacts, and migration safety passed.
Embedding/model outputs and embedding-capacity checks were substituted with deterministic local responses. GitLab requests, PostgreSQL, storage, authentication, ingestion, and authorization were real.
The permission-only save finding was a false positive: changedFields and updatedFields referenced the same array, so adding permissionConfig already satisfied the non-empty guard. I removed the alias to make that behavior explicit and added regression cases proving permission-only and token-only updates commit and record the change without dispatching a content sync. The failing CI assertions expected the removed connection-method controls; they now check the token tabs and managed-access submission. I also removed the runner-speed-dependent parsing assertion while retaining the 100,000-row acceptance and overflow checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Embedding/model outputs and embedding-capacity checks were substituted with deterministic local responses. GitLab requests, PostgreSQL, storage, authentication, ingestion, and authorization were real.
Checklist
Screenshots