Skip to content

improvement(chat): show browser agent site favicons - #7747

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/browser-agent-favicons
Sep 11, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/browser-agent-favicons

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Show the current site's favicon in browser agent headers across chat surfaces, keeping the existing icon size, shimmer, and globe fallback.
  • Derive the site from each agent's own activity so redirects and tab changes update the icon without changing historical messages.
  • Load icons directly from the site's HTTPS origin only when it matches this viewer's local agent-browser tab for the chat. History alone cannot start requests, and unavailable icons retain the globe.

Type of Change

  • Improvement

Testing

  • 93 targeted tests passed, including navigation, tab selection, iframe reads, viewer isolation, request privacy, and image loading/failure regressions.
  • Type-check, lint, all 46 audits, block registry validation, and docs manifest check passed.
  • Checked the production component preview in light and dark modes, during streaming and after completion.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 11:55pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule violations remain.

Summary

  • Derives favicon origins from browser-agent navigation and page observations.
  • Strips credentials, paths, queries, and fragments and permits only HTTPS origins.
  • Requires a live, non-suspended, matching automation tab before initiating a request.
  • Adds regression coverage for chat isolation, transport availability, tab state, loading failures, redirects, and favicon lifecycle.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Browser-agent tool observations] --> B[Derive HTTPS origin]
    B --> C[Expected /favicon.ico URL]
    D[Current chat identity] --> E[Scoped browser session]
    E --> F{Live matching automation tab?}
    G[Local native browser available] --> F
    C --> F
    F -- Yes --> H[Load favicon without referrer]
    F -- No --> I[Show globe fallback]
    H -- Load fails --> I
    H -- Load succeeds --> J[Show favicon]
Loading

Reviews (3) · Last reviewed commit: "fix(chat): limit favicon loads to the lo..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit bcce829 into staging Sep 11, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/browser-agent-favicons branch September 11, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant