Skip to content

fix(search): verify Atlassian access and clarify source setup - #7730

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/atlassian-demo-verification
Sep 10, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/atlassian-demo-verification

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Require current Confluence site access under the reader's own identity, preserve it across search, document, file, and count paths, and keep checks bounded.
  • Use Jira project keys consistently without changing workflow selectors. Prevent stale OAuth attempts and loading states from showing incorrect connection errors.
  • Clarify product-specific token permissions, trim setup guides, refresh focused screenshots, and add missing Slack credential placeholders.
  • Repair integration fixtures for current authorization and provider behavior, and run workspace suites with their dedicated setup.

Type of Change

  • Bug fix

Testing

  • Fresh live connection, indexing, update, permission-removal/restoration, and cited-answer checks with synthetic Atlassian content.
  • CI test shard 2 passed locally: 15,225 tests. Additional regressions cover pending OAuth response order, final v1 access denial, and Confluence-filtered candidate authorization.
  • Full knowledge integration passed: 337 tests plus 27 SQL tests; dedicated workspace integration passed 28 tests. Required PostgreSQL suites passed with both schema push and versioned migrations. Existing opt-in live/scale suites remain skipped.
  • App and docs type checks, cleanup review, lint, API boundary validation, all 46 repository audits, block registry, and generated-artifact checks passed.
  • Additional existing credential and Slack component tests passed; current setup screenshots verified against the rendered UI.
  • Final parallel audit accounts for every changed file. No local build ran for this review round. The new site-access guard used mocked provider responses and still needs deployed verification.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 10, 2026 11:12am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding behavioral, security, or repository-rule violations were identified.

Summary

  • Verifies current Confluence site access under each reader’s identity with bounded, concurrent credential alternatives.
  • Carries live knowledge authorization through search, document, file, and count paths.
  • Prevents stale OAuth attempts and connector polling responses from presenting incorrect UI state.
  • Batches knowledge-base and tag reference reads while preserving caller-visible semantics.
  • Updates Jira selectors, Atlassian setup documentation, Slack credential guidance, and focused integration coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Knowledge request] --> B[Resolve principal access]
  B --> C[Collect candidate connectors and documents]
  C --> D{Confluence-backed source?}
  D -- No --> E[Apply stored access predicate]
  D -- Yes --> F[Group readers by Atlassian identity]
  F --> G[Verify current site access with bounded alternatives]
  G --> H[Create site-scoped reader grants]
  H --> E
  E --> I[Return only currently readable results]
Loading

Reviews (2) · Last reviewed commit: "fix(search): close authorization races a..."

Comment thread apps/sim/lib/knowledge/access/confluence-site.ts Outdated
Comment thread apps/sim/hooks/use-member-enrollment.ts
@waleedlatif1
waleedlatif1 force-pushed the codex/atlassian-demo-verification branch from 40f9249 to 6895e69 Compare September 10, 2026 11:10
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 0009544 into staging Sep 10, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/atlassian-demo-verification branch September 10, 2026 16:48
waleedlatif1 added a commit that referenced this pull request Sep 11, 2026
…ch (#7759)

#7730 switched the knowledge base lists to a KnowledgeAccessProvider, which
turned the single joined count into a per-400-base loop of count plus
candidate-discovery queries. The staging integ workspace holds 21k archived
bases, so GET /api/knowledge?scope=archived went from ~4s to ~100s and the
archive-kb integ check timed out at 30s.

The stored-ACL count moves back into the list's own join. Only documents a
live source (GitHub, Confluence) authorizes beyond that are counted
afterwards, once for the whole list, bounded by the list filter (unpaged) or
the page's ids. The provider now reports whether the reader holds any
live-source credential, and the shared batch generator skips candidate
discovery entirely when it does not, since the discovered predicate would be
provably empty.


Claude-Session: https://claude.ai/code/session_01Lm5mdDU9bi1vb4oAvPtbjn

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant