Skip to content

fix(search): tighten Google sync and invitation recovery - #7729

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/google-demo-readiness
Sep 10, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/google-demo-readiness

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Keep Gmail full sync and change history consistent for missing labels and rolling date filters.
  • Show incomplete Drive picker results accurately and refresh source details after manual sync settles.
  • Recover invitation authentication errors with sign-in or account switching while preserving disclosure guards.
  • Trim repeated Google setup instructions, clarify service and permission limits, and remove an oversized delegation screenshot with an outdated background grant.

Type of Change

  • Bug fix

Testing

  • 1,508 targeted connector, selector, permission, and Search tests passed; the separate real PostgreSQL permission test also passed.
  • 67 invitation tests and 109 embedding/admission tests passed. Application and documentation type checks passed.
  • Full lint, 46 repository audits, block-registry validation, and docs-manifest validation passed. All eight cleanup passes completed.
  • Manually verified central Google sync through document processing, embeddings, and stored permissions; verified invitation account-mismatch recovery and current setup screenshots.
  • Final signed-in member Search and Assistant verification remains pending authentication. This PR does not claim that final manual step is complete.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 10, 2026 10:31am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the changed synchronization, selector, and invitation paths are consistent with their existing contracts and have focused regression coverage.

Summary

  • Uses one second-precision rolling cutoff for Gmail full listings and history filtering.
  • Keeps missing-label behavior consistent while distinguishing absent labels from failed label lookups.
  • Reconciles connector detail and list caches after manual sync dispatch.
  • Reports incomplete Google Drive searches through selector truncation diagnostics.
  • Detects invitation account mismatches using normalized email addresses and offers account switching.
  • Consolidates Google connection guidance and removes an outdated delegation screenshot.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Google or invitation operation] --> B{Operation type}
  B -->|Gmail sync| C[Build second-precision cutoff and label scope]
  C --> D[Full listing or history changes]
  D --> E[Consistent indexed document reconciliation]
  B -->|Manual connector sync| F[Optimistically mark pending]
  F --> G[Trigger request settles]
  G --> H[Invalidate source, detail, and successful list queries]
  H --> I[Polling observes pending through completion]
  B -->|Drive picker| J[Request files with incompleteSearch]
  J --> K[Map provider incompleteness to truncation diagnostics]
  B -->|Invitation| L[Load invitation under disclosure guards]
  L --> M{Normalized email matches?}
  M -->|Yes| N[Allow acceptance]
  M -->|No| O[Offer sign-in with a different account]
Loading

Reviews (1) · Last reviewed commit: "fix(search): tighten Google sync and inv..."

@waleedlatif1
waleedlatif1 merged commit 3c735d2 into staging Sep 10, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/google-demo-readiness branch September 10, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant