fix(settings): restore header shell on workspace credit-usage page#5663
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Because credit usage lives outside the Reviewed by Cursor Bugbot for commit 0ce167b. Configure here. |
Greptile SummaryThis PR restores the settings chrome for the workspace credit-usage page. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(settings): restore header shell on w..." | Re-trigger Greptile |
Summary
settings/billing/credit-usagepage rendering with no header, title, or scroll region (user-reported: page "won't scroll")CreditUsageViewmoved from the self-chromedCredentialDetailLayouttoSettingsPanel, which only registers header config intoSettingsHeaderProvidercontext — the chrome renders inSettingsHeaderShellsettings/[section]/layout.tsx, butbilling/credit-usageis a static route outside[section], so the panel registered into nothing and the page rendered bare children with no scroll container (the account/org planes mount the shell at their settings root, which is why the same view works there)SettingsHeaderProvider+SettingsHeaderShellin a route-levellayout.tsxforbilling/credit-usage, mirroring[section]/layout.tsx; this also covers the route'sloading.tsxfallbackSettingsPanelconsumer (workspace sections, account/org renderers, ee components) — all render under a shell; this route was the only orphanType of Change
Testing
Typecheck clean, credit-usage + billing tests pass
Checklist