improvement(utils): route the remaining record-coercion helpers through toRecord

The first pass matched one operand order, so six exact equivalents written
`x !== null && typeof x === 'object'` survived — two of them beside a sibling
the pass had already deleted. Domain-named wrappers keep their names and
delegate, matching the microsoft-teams client that already did.

Author: waleedlatif1

apps/sim/lib/internal/confluence/client.ts

@@ -1,3 +1,4 @@
+import { toRecord } from '@sim/utils/object'
 import { validateJiraCloudId } from '@/lib/core/security/input-validation'
 import { MAX_JSON_API_RESPONSE_BYTES } from '@/lib/core/security/input-validation.server'
 import {
@@ -17,7 +18,7 @@ export interface ConfluenceConnectionConfig {
 export type JsonObject = Record<string, unknown>
 
 export function asObject(value: unknown): JsonObject {
-  return value && typeof value === 'object' && !Array.isArray(value) ? (value as JsonObject) : {}
+  return toRecord(value)
 }
 
 export function asArray(value: unknown): unknown[] {

apps/sim/lib/internal/google-drive/client.ts

@@ -1,3 +1,4 @@
+import { toRecord } from '@sim/utils/object'
 import {
   MAX_JSON_API_RESPONSE_BYTES,
   type SecureFetchResponse,
@@ -54,9 +55,7 @@ export async function requestGoogleDrive(
 export type JsonObject = Record<string, unknown>
 
 export function asObject(value: unknown): JsonObject {
-  return value !== null && typeof value === 'object' && !Array.isArray(value)
-    ? (value as JsonObject)
-    : {}
+  return toRecord(value)
 }
 
 export async function responseObject(response: SecureFetchResponse): Promise<JsonObject> {

apps/sim/lib/internal/google-drive/operations.test.ts

@@ -9,8 +9,7 @@ const mocks = vi.hoisted(() => ({
 }))
 
 vi.mock('@/lib/internal/google-drive/client', () => ({
-  asObject: (value: unknown) =>
-    value !== null && typeof value === 'object' && !Array.isArray(value) ? value : {},
+  asObject: (value: unknown) => toRecord(value),
   googleApiErrorMessage: (data: { error?: { message?: string } }, fallback: string) =>
     data.error?.message || fallback,
   requestGoogleDrive: mocks.request,
@@ -21,6 +20,7 @@ vi.mock('@/lib/internal/google-drive/file-input', () => ({
   resolveGoogleDriveUploadFile: mocks.resolveFile,
 }))
 
+import { toRecord } from '@sim/utils/object'
 import {
   executeGoogleDriveDownload,
   executeGoogleDriveExport,

apps/sim/lib/internal/jira/operations.ts

@@ -1,5 +1,6 @@
 import type { Logger } from '@sim/logger'
 import { createLogger } from '@sim/logger'
+import { toRecord } from '@sim/utils/object'
 import { validateAlphanumericId, validateJiraIssueKey } from '@/lib/core/security/input-validation'
 import { createJiraClient, type JiraClient } from '@/lib/internal/jira/client'
 import { JiraOperationError } from '@/lib/internal/jira/errors'
@@ -26,9 +27,7 @@ export interface JiraOperationContext {
 type JsonObject = Record<string, unknown>
 
 function asObject(value: unknown): JsonObject {
-  return value !== null && typeof value === 'object' && !Array.isArray(value)
-    ? (value as JsonObject)
-    : {}
+  return toRecord(value)
 }
 
 function parseObject(text: string): JsonObject {

apps/sim/lib/internal/microsoft-dataverse/client.ts

@@ -41,7 +41,7 @@ export async function uploadDataverseFile(
     return
   }
   const data = await response.json().catch(() => null)
-  const error = isRecordLike(data) && toRecordOrNull(data.error)
+  const error = isRecordLike(data) ? toRecordOrNull(data.error) : null
   const message =
     error && typeof error.message === 'string'
       ? error.message

apps/sim/lib/internal/onepassword/client.ts

@@ -11,6 +11,7 @@ import type {
   Website,
 } from '@1password/sdk'
 import { generateId } from '@sim/utils/id'
+import { toRecord } from '@sim/utils/object'
 import {
   MAX_JSON_API_RESPONSE_BYTES,
   type SecureFetchResponse,
@@ -449,12 +450,6 @@ export function findItemFileAttributes(item: Item, fileId: string): FileAttribut
  * category enum strings vs Connect's SCREAMING_SNAKE_CASE) and silently no-ops or
  * corrupts the write otherwise.
  */
-function objectValue(value: unknown): Record<string, unknown> {
-  return value !== null && typeof value === 'object' && !Array.isArray(value)
-    ? (value as Record<string, unknown>)
-    : {}
-}
-
 function optionalString(value: unknown): string | undefined {
   return typeof value === 'string' ? value : undefined
 }
@@ -465,8 +460,8 @@ export function connectItemToSdkItem(connectItem: Record<string, unknown>, exist
 
   const fields = Array.isArray(connectItem.fields)
     ? connectItem.fields.map((value) => {
-        const field = objectValue(value)
-        const section = objectValue(field.section)
+        const field = toRecord(value)
+        const section = toRecord(field.section)
         const id = optionalString(field.id)
         return {
           /** Preserve SDK-only metadata on fields that already existed. */
@@ -482,7 +477,7 @@ export function connectItemToSdkItem(connectItem: Record<string, unknown>, exist
 
   const sections = Array.isArray(connectItem.sections)
     ? connectItem.sections.map((value) => {
-        const section = objectValue(value)
+        const section = toRecord(value)
         const id = optionalString(section.id)
         return {
           ...(id ? existingSectionsById.get(id) : undefined),
@@ -495,7 +490,7 @@ export function connectItemToSdkItem(connectItem: Record<string, unknown>, exist
   const websitesValue = connectItem.urls ?? connectItem.websites
   const websites = Array.isArray(websitesValue)
     ? websitesValue.map((value) => {
-        const website = objectValue(value)
+        const website = toRecord(value)
         return {
           url: optionalString(website.href) || optionalString(website.url) || '',
           label: optionalString(website.label) || '',

apps/sim/lib/internal/servicenow/client.ts

@@ -45,7 +45,7 @@ export async function uploadServiceNowAttachment(
   )
   const data = await response.json().catch(() => null)
   if (!response.ok) {
-    const error = isRecordLike(data) && toRecordOrNull(data.error)
+    const error = isRecordLike(data) ? toRecordOrNull(data.error) : null
     const message =
       error && typeof error.message === 'string'
         ? error.message

apps/sim/lib/internal/slack/operations.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { toRecord } from '@sim/utils/object'
 import type {
   SlackDeleteMessageBody,
   SlackDownloadBody,
@@ -49,9 +50,7 @@ function providerError(data: SlackJsonObject, status: number, fallback: string):
 }
 
 function record(value: unknown): SlackJsonObject {
-  return typeof value === 'object' && value !== null && !Array.isArray(value)
-    ? (value as SlackJsonObject)
-    : {}
+  return toRecord(value)
 }
 
 function mapReaction(value: unknown) {

apps/sim/lib/webhooks/slack-custom-ingress.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { toRecord } from '@sim/utils/object'
 import type { NextRequest } from 'next/server'
 import { NextResponse } from 'next/server'
 import { cancelWorkflowExecution } from '@/lib/execution/cancel-workflow-execution'
@@ -46,12 +47,7 @@ interface DispatchSlackCustomBotOptions {
 export function getLegacySlackCustomBotCredentialId(
   foundWebhook: LegacySlackPathWebhook
 ): string | null {
-  const providerConfig =
-    foundWebhook.providerConfig !== null &&
-    typeof foundWebhook.providerConfig === 'object' &&
-    !Array.isArray(foundWebhook.providerConfig)
-      ? (foundWebhook.providerConfig as Record<string, unknown>)
-      : {}
+  const providerConfig = toRecord(foundWebhook.providerConfig)
 
   if (providerConfig.ingressMode !== LEGACY_SLACK_CUSTOM_BOT_INGRESS_MODE) {
     return null

apps/sim/tools/bitbucket/get_merge_task_status.ts

@@ -1,3 +1,4 @@
+import { toRecordOrNull } from '@sim/utils/object'
 import {
   BITBUCKET_PULL_REQUEST_OUTPUT_PROPERTIES,
   type BitbucketGetMergeTaskStatusParams,
@@ -23,12 +24,6 @@ interface BitbucketMergeTaskOutput {
   mergeResult: BitbucketPullRequest | null
 }
 
-function record(value: unknown): Record<string, unknown> | null {
-  return typeof value === 'object' && value !== null && !Array.isArray(value)
-    ? (value as Record<string, unknown>)
-    : null
-}
-
 function stringField(value: unknown): string | null {
   return typeof value === 'string' ? value : null
 }
@@ -61,7 +56,7 @@ export const bitbucketGetMergeTaskStatusTool: ToolConfig<
   transformResponse: async (response) => {
     const data = await bitbucketJson(response)
     if (data.type === 'error') {
-      const error = record(data.error)
+      const error = toRecordOrNull(data.error)
       const message = stringField(error?.message)?.trim()
       if (!message) throw new Error('Bitbucket returned a malformed merge task error')
       const detail = stringField(error?.detail)?.trim()
@@ -73,11 +68,11 @@ export const bitbucketGetMergeTaskStatusTool: ToolConfig<
       throw new Error('Bitbucket merge task status must be PENDING or SUCCESS')
     }
 
-    const links = record(data.links)
-    const self = record(links?.self)
+    const links = toRecordOrNull(data.links)
+    const self = toRecordOrNull(links?.self)
     let mergeResult: BitbucketPullRequest | null = null
     if (taskStatus === 'SUCCESS') {
-      const result = record(data.merge_result)
+      const result = toRecordOrNull(data.merge_result)
       if (!result) throw new Error('Bitbucket successful merge task omitted merge_result')
       mergeResult = normalizeBitbucketPullRequest(result)
     }