improvement(utils): adopt toRecord and toRecordOrNull over inline record coercions

Author: waleedlatif1

apps/desktop/src/main/ipc.ts

@@ -27,7 +27,7 @@ import {
   type TerminalToolArgs,
 } from '@sim/terminal-protocol'
 import { getErrorMessage } from '@sim/utils/errors'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import { PASTE_LIMITS, utf8ByteLength } from '@sim/utils/paste'
 import type { BrowserWindow, IpcMainEvent, IpcMainInvokeEvent, WebContents } from 'electron'
 import { clipboard, ipcMain, shell } from 'electron'
@@ -856,7 +856,7 @@ export function registerIpcHandlers(deps: IpcDeps): void {
         ) {
           return { ok: false, error: `Unknown browser tool: ${String(tool)}` }
         }
-        const toolParams = isRecordLike(params) ? params : {}
+        const toolParams = toRecord(params)
         return executeTool(
           scope,
           tool,
@@ -1532,7 +1532,7 @@ export function registerIpcHandlers(deps: IpcDeps): void {
         ) {
           return { ok: false, error: `Unknown terminal tool: ${String(tool)}` }
         }
-        const call = isRecordLike(params) ? params : {}
+        const call = toRecord(params)
         if (!isTerminalOperation(call.operation)) {
           return { ok: false, error: `Unknown terminal operation: ${String(call.operation)}` }
         }

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/browser-agent-icon.tsx

@@ -4,7 +4,7 @@ import { useState } from 'react'
 import { isBrowserToolName } from '@sim/browser-protocol'
 import { cn } from '@sim/emcn'
 import { Globe } from '@sim/emcn/icons'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecordOrNull } from '@sim/utils/object'
 import { isBrowserAgentAvailable } from '@/lib/browser-agent/transport'
 import { useChatSurface } from '@/app/workspace/[workspaceId]/home/components/chat-surface-context'
 import type { AgentGroupItem } from '@/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/agent-group-view'
@@ -40,7 +40,7 @@ export function getBrowserAgentFaviconUrl(items: AgentGroupItem[]): string | nul
       return typeof params?.url === 'string' ? pageFaviconUrl(params.url) : null
     }
 
-    const output = result?.success && isRecordLike(result.output) ? result.output : null
+    const output = result?.success ? toRecordOrNull(result.output) : null
     if (output) {
       if (isRecordLike(output.activeTab) && typeof output.activeTab.url === 'string') {
         return pageFaviconUrl(output.activeTab.url)

apps/sim/app/workspace/[workspaceId]/home/hooks/stream/turn-model.ts

@@ -1,4 +1,4 @@
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import { resolveStreamToolOutcome } from '@/lib/copilot/chat/stream-tool-outcome'
 import {
   MothershipStreamV1CompletionStatus,
@@ -230,7 +230,7 @@ function rebindResolvedIntegrationCall(node: ToolNode, toolName: string): void {
  * through the `unknown`-typed {@link isRecordLike} guard rather than a double cast.
  */
 function payloadRecord(payload: unknown): Record<string, unknown> {
-  return isRecordLike(payload) ? payload : {}
+  return toRecord(payload)
 }
 
 /** Parses a wire `ts` to epoch ms, or undefined when absent/unparseable. */

apps/sim/background/webhook-execution.ts

@@ -10,7 +10,7 @@ import { createLogger, type RequestContext, runWithRequestContext } from '@sim/l
 import { toError } from '@sim/utils/errors'
 import { interruptibleSleep } from '@sim/utils/helpers'
 import { generateId } from '@sim/utils/id'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import { backoffWithJitter } from '@sim/utils/retry'
 import { task, timeout } from '@trigger.dev/sdk'
 import { eq } from 'drizzle-orm'
@@ -1091,9 +1091,7 @@ async function executeWebhookJobInternal(
         })
       }
 
-      const persistedProviderConfig = isRecordLike(resolvedWebhookRecord.providerConfig)
-        ? resolvedWebhookRecord.providerConfig
-        : {}
+      const persistedProviderConfig = toRecord(resolvedWebhookRecord.providerConfig)
       const slackStreamConfig =
         payload.provider === 'slack' || payload.provider === 'slack_app'
           ? readSlackStreamResponseConfig(persistedProviderConfig)

apps/sim/ee/scim/lib/protocol/user-patch.ts

@@ -1,5 +1,5 @@
 import type { ScimUserAttributes, ScimUserEmail } from '@sim/db/schema'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import type { ScimPatchOperation } from '@/lib/api/contracts/scim'
 import { invalidPath, invalidValue, mutability, noTarget } from '@/ee/scim/lib/protocol/errors'
 import {
@@ -331,7 +331,7 @@ function applyExtraOperation(
       else {
         if (!isRecordLike(value)) throw invalidValue(`${path} requires an object value`)
         const current = user.extra[extension.schema]
-        user.extra[extension.schema] = { ...(isRecordLike(current) ? current : {}), ...value }
+        user.extra[extension.schema] = { ...toRecord(current), ...value }
       }
       return
     }

apps/sim/executor/execution/block-executor.ts

@@ -1,7 +1,7 @@
 import { createLogger, type Logger } from '@sim/logger'
 import { describeError } from '@sim/utils/errors'
 import { sleep } from '@sim/utils/helpers'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import { DrizzleQueryError } from 'drizzle-orm/errors'
 import { isTimeoutAbortReason } from '@/lib/core/execution-limits/types'
 import { redactApiKeys } from '@/lib/core/security/redaction'
@@ -970,7 +970,7 @@ export class BlockExecutor {
               }
             })()
           : mapping
-      inputs = isRecordLike(parsed) ? parsed : {}
+      inputs = toRecord(parsed)
     }
 
     const result: Record<string, any> = {}

apps/sim/hooks/queries/custom-tools.ts

@@ -1,5 +1,5 @@
 import { createLogger } from '@sim/logger'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import { keepPreviousData, useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
 import { requestJson } from '@/lib/api/client/request'
 import {
@@ -125,8 +125,8 @@ async function fetchCustomTools(
     }
 
     const functionSchema = tool.schema.function
-    const parameters = isRecordLike(functionSchema.parameters) ? functionSchema.parameters : {}
-    const properties = isRecordLike(parameters.properties) ? parameters.properties : {}
+    const parameters = toRecord(functionSchema.parameters)
+    const properties = toRecord(parameters.properties)
     const required = Array.isArray(parameters.required)
       ? parameters.required.filter((value): value is string => typeof value === 'string')
       : undefined

apps/sim/hooks/queries/organization.ts

@@ -1,5 +1,5 @@
 import { createLogger } from '@sim/logger'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import {
   queryOptions,
   type UseQueryResult,
@@ -269,7 +269,7 @@ export function useUpdateOrganizationUsageLimit() {
         organizationKeys.billing(organizationId),
         (old: unknown) => {
           if (!isRecordLike(old) || !isRecordLike(old.data)) return old
-          const usage = isRecordLike(old.data.usage) ? old.data.usage : {}
+          const usage = toRecord(old.data.usage)
           const currentUsage =
             readNumber(old.data.currentUsage) ??
             readNumber(usage.current) ??

apps/sim/lib/auth/connectors/managed-oauth.ts

@@ -1,5 +1,5 @@
 import { createHash } from 'node:crypto'
-import { isRecordLike } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import type { OAuth2Tokens } from 'better-auth/oauth2'
 import type { GenericOAuthConfig } from 'better-auth/plugins'
 import { OAuth2Client, type TokenPayload } from 'google-auth-library'
@@ -830,7 +830,7 @@ const USER_INFO_MANAGED_OAUTH_CONNECTORS = new Map<string, () => ManagedOAuthCon
         },
         parse: (profile) => {
           const account = asProfileRecord(profile, 'Dropbox')
-          const name = isRecordLike(account.name) ? account.name : {}
+          const name = toRecord(account.name)
           return withOptionalIdentityFields(
             {
               providerSubjectId: requireIdentityField(account.account_id, 'Dropbox account id'),
@@ -889,15 +889,15 @@ const USER_INFO_MANAGED_OAUTH_CONNECTORS = new Map<string, () => ManagedOAuthCon
            * `bot.owner.user`. A workspace-owned internal integration reports
            * `{ type: 'workspace' }` and identifies nobody, which cannot be bound to an invitation.
            */
-          const bot = isRecordLike(self.bot) ? self.bot : {}
-          const owner = isRecordLike(bot.owner) ? bot.owner : {}
+          const bot = toRecord(self.bot)
+          const owner = toRecord(bot.owner)
           if (owner.type !== 'user') {
             throw new Error(
               'Notion returned a workspace-owned integration, which identifies no person to bind this invitation to'
             )
           }
           const user = asProfileRecord(owner.user, 'Notion')
-          const person = isRecordLike(user.person) ? user.person : {}
+          const person = toRecord(user.person)
           return withOptionalIdentityFields(
             {
               providerSubjectId: requireIdentityField(user.id, 'Notion user id'),
@@ -1004,7 +1004,7 @@ const USER_INFO_MANAGED_OAUTH_CONNECTORS = new Map<string, () => ManagedOAuthCon
         scopes: {
           from: 'profile',
           read: (profile) => {
-            const metadata = isRecordLike(profile) ? profile : {}
+            const metadata = toRecord(profile)
             if (Array.isArray(metadata.scopes)) {
               return metadata.scopes.filter((scope): scope is string => typeof scope === 'string')
             }
@@ -1135,7 +1135,7 @@ const USER_INFO_MANAGED_OAUTH_CONNECTORS = new Map<string, () => ManagedOAuthCon
         parse: (profile) => {
           const envelope = asProfileRecord(profile, 'Asana')
           const user = asProfileRecord(envelope.data, 'Asana')
-          const photo = isRecordLike(user.photo) ? user.photo : {}
+          const photo = toRecord(user.photo)
           return withOptionalIdentityFields(
             {
               providerSubjectId: requireIdentityField(user.gid, 'Asana user id'),

apps/sim/lib/billing/core/reporting-period.ts

@@ -1,4 +1,4 @@
-import { isRecordLike } from '@sim/utils/object'
+import { toRecord } from '@sim/utils/object'
 import { defaultBillingPeriod } from '@/lib/billing/core/billing-period'
 import { isEnterprise } from '@/lib/billing/plan-helpers'
 
@@ -91,7 +91,7 @@ export function resolveSubscriptionUsagePeriod(
     return subscription.usagePeriod
   }
   if (subscription && isEnterprise(subscription.plan)) {
-    const metadata = isRecordLike(subscription.metadata) ? subscription.metadata : {}
+    const metadata = toRecord(subscription.metadata)
     const anchor = metadata[ENTERPRISE_REPORTING_PERIOD_ANCHOR_METADATA_KEY]
     const interval =
       parseBillingInterval(metadata[ENTERPRISE_REPORTING_PERIOD_INTERVAL_METADATA_KEY]) ??