Remove dead autoClusterActivate Helm Job from the dev chart - #459
Open
boddumanohar wants to merge 1 commit into
Open
Remove dead autoClusterActivate Helm Job from the dev chart#459boddumanohar wants to merge 1 commit into
boddumanohar wants to merge 1 commit into
Conversation
Cluster activation is already handled automatically by
StorageNodeSetReconciler.maybeActivateCluster on every reconcile once
enough nodes are online, and explicitly via StorageClusterOps{action:
activate}. Both call the current /api/v2/clusters/{id}/activate
endpoint. The Job (default-disabled, unused on config-israel) still
called the legacy /api/v1/cluster/activate/{uuid} PUT endpoint through
a bundled Python script, superseded by the reconciler path.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/job.yaml(autoClusterActivategated Job) and itstemplates/mgmt-api-config-map.yamlcompanion ConfigMap fromhelm-charts/charts/simplyblock-operator.autoClusterActivatevalue andimage.mgmtAPIblock fromvalues.yaml.Why
Cluster activation is already fully automatic and CRD-driven:
StorageNodeSetReconcilercallsmaybeActivateClusteron every reconcile once enough nodes report online/healthy (operator/internal/controller/simplyblockstoragenodeset_controller.go), self-healing across operator restarts.StorageClusterOps{action: activate}provides an explicit, idempotent, GitOps-friendly path for the same operation (operator/internal/controller/storageclusterops_controller.go).Both call the current
/api/v2/clusters/{id}/activateendpoint. The Job instead ran a bundled Python script (ACTION_TYPE=cl_activate) that polled the legacy/api/v1/cluster/activate/{uuid}PUT endpoint — superseded, and disabled by default (autoClusterActivate: false).Verified unused: checked
config-israel, a live deployment of this chart —autoClusterActivatecomputes to its defaultfalseand no such Job exists in the cluster.Note: a separate, unrelated
autoClusterActivateflag exists insimplyBlockDeploy/aws/storagenodes-k8s.shandcsi-driver/charts/spdk-csi/latest/spdk-csi/, targeting a different, older external chart (simplyblock-csi/spdk-csi, pre-operator/CRD architecture) — intentionally left untouched here, out of scope for this dev-chart cleanup.Test plan
helm lint helm-charts/charts/simplyblock-operator/helm templaterenders cleanly with defaultsautoClusterActivate,mgmtAPI, or the ConfigMap anywhere in the chartconfig-israelcluster🤖 Generated with Claude Code