Remove unused simplyblock-pvc-keys secret from the dev chart - #458
Open
boddumanohar wants to merge 1 commit into
Open
Remove unused simplyblock-pvc-keys secret from the dev chart#458boddumanohar wants to merge 1 commit into
boddumanohar wants to merge 1 commit into
Conversation
LVol encryption keys are now sourced entirely from KMS (internal or external), so the CSI driver never handles crypto_key1/crypto_key2 and PVCs no longer reference a Kubernetes secret for them. The simplyblock-pvc-keys secret template and its simplybkPvc values were leftover from the pre-KMS flow; the csi-driver's own vendored chart copy already dropped them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
csi-driver/docs/encrypted-volumes.mdandsbcli's--crypto-key1/--crypto-key2deprecation).simplyblock-pvc-keysSecret template and thecsiSecret.simplybkPvcvalues from the development chart (helm-charts/charts/simplyblock-operator). The csi-driver's own vendored chart copy (csi-driver/charts/spdk-csi/latest/spdk-csi) had already dropped these.crypto_key1/crypto_key2exist in the operator, atlas-lib, or csi-driver Go code.Test plan
helm template helm-charts/charts/simplyblock-operator --set externallyManagedSecret.create=truerenders cleanly, nosimplyblock-pvc-keysin output.simplyblock-pvc-keys,simplybkPvc,crypto_key1/crypto_key2.🤖 Generated with Claude Code