Backport: Batch migration delay (#1288) to R26.3 - #1311
Merged
Conversation
* optimization towards batch lvol migration snapshot copy length * fix hublvol race condition leading to detach of the controller * Revert "optimization towards batch lvol migration snapshot copy length" This reverts commit 62153c2. * setting batch cluster size to 512 for testing purpose * setting batch size to 256 * using a constant for batch size, mini refactor and using rpc exception instead of blanket * Returning rpc exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1288 ("Batch migration delay"), merged to
mainas5957acadc.Cherry-picked the squash commit directly; it applied cleanly with no conflicts (
constants.pyandtasks_runner_lvol_migration.pyauto-merged). The applied diff is byte-identical to what landed on main — verified by diffing the two patches.Contents
simplyblock_core/constants.pysimplyblock_core/services/hub_controller_manager.pysimplyblock_core/services/tasks_runner_batch_migration.pysimplyblock_core/services/tasks_runner_lvol_migration.pyNet: 4 files, +84 −50 — same as on main.
Verification on this branch
ruff— cleanpytest tests/unit simplyblock_core/test— 2150 passed, 7 skipped, 27 subtests, 0 failedmypy— 2 pre-existing errors insimplyblock_core/services/tasks_runner_node_add.py(_inflight,_inflight_addrsneed type annotations). Not introduced here: reproduced identically on an untouchedorigin/R26.3worktree, and this backport does not touch that file.🤖 Generated with Claude Code