refactor: rework SPDK proxy to utilize fastapi - #1298
Open
mxsrc wants to merge 22 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| def _close(writer: asyncio.StreamWriter) -> None: | ||
| try: | ||
| writer.close() | ||
| except OSError: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mxsrc
force-pushed
the
fastapi-spdk-proxy
branch
2 times, most recently
from
September 4, 2026 00:00
a47747d to
918ad15
Compare
The existing proxy executed at import time and utilized global state, making it difficult to reason about. Converting this to FastAPI addresses this issue, aligns the proxy with the other API code, and enables simpler integration of richer SPDK-side interaction.
These broke tests that executed later and relied on sleep behaving as intended.
mxsrc
force-pushed
the
fastapi-spdk-proxy
branch
from
September 4, 2026 00:50
05b672e to
2154d5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing proxy executed at import time and utilized global state, making it difficult to reason about. Converting this to FastAPI addresses this issue, aligns the proxy with the other API code, and enables simpler integration of richer SPDK-side interaction.