Improved DHCHAP Kubernetes page - #205
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the Kubernetes documentation for NVMe-oF host access control and DH-HMAC-CHAP by rewriting the page to better describe operator reconciliation, immutability constraints, and verification/troubleshooting workflows.
Changes:
- Rewrites the introduction and framing to focus on host access control plus DH-HMAC-CHAP on
StoragePool. - Adds operational detail about reconciliation behavior,
StorageClassimmutability implications, and node removal effects. - Adds verification and troubleshooting guidance (
status.allowedNodes, node labels,allowedTopologies, and a FailedMount example).
Suppressed comments (1)
docs/kubernetes/operations/security/authentication-encryption.md:20
- The section heading still mentions "Encryption", but this page now documents only host access control and DH-HMAC-CHAP authentication (transport encryption is explicitly noted as not exposed). Updating the heading keeps terminology consistent within the page.
TLS/PSK encryption of the NVMe-oF transport is not exposed through the `StoragePool`. Encryption of the volume
data at rest is an unrelated, per-volume feature and is described in
[Volume Encryption](../../usage/volume-encryption.md).
## Enable Host Authentication and Encryption
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🤖: Deployment available as https://docstest.simplyblock.io/dhchap-update |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
🤖: Deployment available as https://docstest.simplyblock.io/dhchap-update |
1 similar comment
Contributor
|
🤖: Deployment available as https://docstest.simplyblock.io/dhchap-update |
boddumanohar
approved these changes
Sep 1, 2026
boddumanohar
left a comment
boddumanohar
left a comment
Member
There was a problem hiding this comment.
thanks, looks much better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@boddumanohar please verify again