Repository navigation
fix(layout): add panel column so Files and Changes buttons work - #23
Merged
Merged
Conversation
Herdr's Files and Changes buttons look for a `panel` node in the layout; bercail's layout lacked one, so clicking them showed a layout.show error. - Add a 280-wide `panel` column (Herdr's minimum) to bercail.json. - Ctrl+Shift+F / Ctrl+Shift+G drive the same panel state as the buttons. - Layout redeploy carries over live desks instead of dropping them. - Tests for the panel node and desk carry-over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Since the Herdr 0.1.11 upgrade, clicking Files (or Changes) showed a
layout.show failedtoast: Herdr's buttons look for apanelnode, and bercail's layout had none.bercail/layouts/bercail.json: adds apanelcolumn, 280 wide (Herdr's minimum).bercail/mods/bercail-desk/main.js: Ctrl+Shift+F / Ctrl+Shift+G act on the same panel state as the buttons, so keys and buttons always agree.lib/config.sh: a layout redeploy now carries live desks over instead of dropping them.bercail/RECIPE.md: documents the panel column.Tests
tests/desk_mod_test.shandtests/herdr_app_deploy_test.sh; they fail on the old code and pass on the new.for t in tests/*.sh; do bash "$t"; done): 21/21 pass.Pending
Live click-test of Files and Changes in the running app after
bercail update(needs this merged to master first).