Skip to content

[claude] Add morpheme commands with parity tests - #497

Draft
myieye wants to merge 15 commits into
443-token-commandsfrom
444-morpheme-commands
Draft

myieye wants to merge 15 commits into
443-token-commandsfrom
444-morpheme-commands

Conversation

@myieye

@myieye myieye commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

[Claude, autonomous]

Closes #444. Host commands copying the writeMorphemes, deleteMorphemes and writeMorphemeGloss reducers, with parity tests. Based on #488 (3d), not stacked.

  • Touches 3d: exports six tokenCommands.ts helpers for reuse, and moves writeGloss's empty-payload detach into detachEmptiedAnalysis.
  • main.test.ts's session stub now serves its draft via an in-memory DraftRepository, so the approve and morpheme tests assert real changes (they were passing on an empty ChangeSet).
  • The catalog-wide morpheme reducers (writeAnalysisMorphemes etc.) are left for 3i.

🤖 Generated with Claude Code


This change is Reviewable

alex-rawlings-yyc and others added 7 commits October 22, 2026 13:53
Host-side copies of the writeMorphemes, deleteMorphemes and
writeMorphemeGloss reducers, registered as session commands. Exports the
token-command helpers they reuse and extracts detachEmptiedAnalysis from
writeGloss.

main.test.ts's session stub now serves its draft through a real in-memory
DraftRepository, so the approve and morpheme command tests assert real
changes instead of an empty ChangeSet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

myieye and others added 3 commits October 23, 2026 18:12
…rlinearizer-extension into 444-morpheme-commands

# Conflicts:
#	src/__tests__/analysis-repository-conformance.ts
#	src/__tests__/main.test.ts
#	src/__tests__/services/analysisSessions.test.ts
#	src/__tests__/services/pt9ImportRepository.test.ts
#	src/main.ts
#	src/services/analysisSessions.ts
#	src/services/commands/tokenCommands.ts
#	src/services/pt9ImportRepository.ts
#	src/types/interlinearizer.d.ts
…rlinearizer-extension into 444-morpheme-commands

# Conflicts:
#	src/__tests__/analysis-repository-conformance.ts
#	src/__tests__/main.test.ts
#	src/__tests__/services/analysisSessions.test.ts
#	src/__tests__/services/draftRepository.test.ts
#	src/__tests__/services/editHistory.test.ts
#	src/__tests__/services/indexedRepository.test.ts
#	src/__tests__/utils/change-set.test.ts
#	src/main.ts
#	src/services/analysisSessions.ts
#	src/services/commands/tokenCommands.ts
#	src/services/draftRepository.ts
#	src/services/editHistory.ts
#	src/types/analysis-repository.ts
#	src/types/interlinearizer.d.ts
#	src/utils/change-set.ts
@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the 443-token-commands branch 2 times, most recently from d4487d9 to 689bd3c Compare October 23, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants