You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Discard unreadable books when the host starts a draft over #573
Opening a session only loads; it never discards. This matches main, which discards only on saves that start the draft over.
4a brings New and Open to the host, but doesn't cover this case.
So on the host path nothing gets the user out yet.
Scope
Host New and Open discard each unreadable book, so later writes treat it like any other book.
In DraftRepository today, this is clearing unreadableShards before the write.
Do it in whatever path 4a gives New and Open, not through replaceAll.
Opening a session stays load-only.
Why it blocks 4b
4b ships the host path by default. Without this issue, a user with an unreadable book has no way out on the default path, short of the rollback release.
Done when
With the flag on, New or Open on a draft with an unreadable book leaves no book unreadable, and edits that reach the book apply.
Tests cover this on the flag-on path.
Then
Remove "Books whose stored analysis can't be read" from 4c's body.
#585 already discards unreadable books in startDraftOver (discardUnreadable: true), through replaceAll. If #585 moves that write into a DraftRepository-only reset (see the review there), this issue may come down to checking that the reset covers it, plus the flag-on tests in "Done when."
Either way, the discard belongs in DraftRepository, not AnalysisRepository. Unreadable books come from today's one-shard-per-book storage and shouldn't reach the seam.
Activity
imnasnainaec commentedon Nov 2, 2026
#585 already discards unreadable books in
startDraftOver(discardUnreadable: true), throughreplaceAll. If #585 moves that write into aDraftRepository-only reset (see the review there), this issue may come down to checking that the reset covers it, plus the flag-on tests in "Done when."Either way, the discard belongs in
DraftRepository, notAnalysisRepository. Unreadable books come from today's one-shard-per-book storage and shouldn't reach the seam.