chore: reuse the Title column string for the note title aria-label

docs/ai/localization.md

@@ -15,6 +15,13 @@ For new English units use `<source>…</source>` with an empty `<target/>`, and
 a `<context-group context-type="sourcefile">` pointing to the primary consuming
 file (e.g. `BurritoFormat.tsx`) so translators see where the string is used.
 
+### Aria labels: reuse a visible label's string
+
+When feasible, an `aria-label` (or other
+accessibility-only text) should prefer to **reuse the string already shown as the
+control's visible label** — a column header, field label, button text, or
+tooltip — instead of adding a new XLIFF unit.
+
 ## Regenerating TypeScript after XLIFF changes
 
 From the **repo root** in **PowerShell**:

localization/TranscriberAdmin-en-1.2.xliff

@@ -7621,13 +7621,6 @@
                <context context-type="sourcefile">PlanSheet.tsx</context>
             </context-group>
          </trans-unit>
-         <trans-unit id="planSheet.noteTitle">
-            <source>Note title</source>
-            <target/>
-            <context-group>
-               <context context-type="sourcefile">NoteTitleField.tsx</context>
-            </context-group>
-         </trans-unit>
          <trans-unit id="planSheet.pasting">
             <source>Pasting</source>
             <target/>

localization/TranscriberAdmin-en.xlf

@@ -6532,12 +6532,6 @@
             <target/>
          </segment>
       </unit>
-      <unit id="planSheet.noteTitle">
-         <segment>
-            <source>Note title</source>
-            <target/>
-         </segment>
-      </unit>
       <unit id="planSheet.pasting">
          <segment>
             <source>Pasting</source>

web/src/components/Sheet/NoteTitleField.test.tsx

@@ -30,12 +30,12 @@ function TitleCell({ readonly = false }: { readonly?: boolean }) {
 
 describe('note title dictionary', () => {
   beforeEach(() => {
-    mockUseSelector.mockReturnValue({ noteTitle: 'Note title' });
+    mockUseSelector.mockReturnValue({ title: 'Title' });
   });
 
   it('does not open the sheet menu on a misspelled note title', () => {
     render(<TitleCell />);
-    const title = screen.getByRole('textbox', { name: 'Note title' });
+    const title = screen.getByRole('textbox', { name: 'Title' });
     expect(title).toHaveAttribute('spellcheck', 'true');
     expect(title).not.toHaveAttribute('readonly');
     fireEvent.change(title, { target: { value: 'Changed' } });
@@ -46,7 +46,7 @@ describe('note title dictionary', () => {
 
   it('does not change a read-only note title', () => {
     render(<TitleCell readonly />);
-    const title = screen.getByRole('textbox', { name: 'Note title' });
+    const title = screen.getByRole('textbox', { name: 'Title' });
     expect(title).toHaveAttribute('spellcheck', 'true');
     expect(title).toHaveAttribute('readonly');
     fireEvent.change(title, { target: { value: 'Changed' } });

web/src/components/Sheet/NoteTitleField.tsx

@@ -1,7 +1,7 @@
 import { TextField } from '@mui/material';
-import { IPlanSheetStrings } from '@model/index';
+import { IScriptureTableStrings } from '@model/index';
 import { useSelector, shallowEqual } from 'react-redux';
-import { planSheetSelector } from '../../selector';
+import { scriptureTableSelector } from '../../selector';
 
 export function NoteTitleField({
   value,
@@ -12,7 +12,10 @@ export function NoteTitleField({
   onChange: (value: string) => void;
   readonly?: boolean;
 }>) {
-  const t: IPlanSheetStrings = useSelector(planSheetSelector, shallowEqual);
+  const t: IScriptureTableStrings = useSelector(
+    scriptureTableSelector,
+    shallowEqual
+  );
   return (
     <TextField
       value={value}
@@ -24,7 +27,8 @@ export function NoteTitleField({
       spellCheck
       slotProps={{
         htmlInput: {
-          'aria-label': t.noteTitle,
+          // Same text as the visible Title column header.
+          'aria-label': t.title,
           spellCheck: true,
           readOnly: readonly,
         },

web/src/store/localization/model.tsx

@@ -1273,7 +1273,6 @@ export interface IPlanSheetStrings extends Localize.LocalizedStringsMethods {
     "passageEnd": string;
     "passageToPrevSection": string;
     "passageToNextSection": string;
-    "noteTitle": string;
     "pasting": string;
     "propagate": string;
     "publish": string;

web/src/store/localization/reducers.tsx

@@ -1340,7 +1340,6 @@ const initialState = {
 			"passageEnd": "Add Passage to End",
 			"passageToPrevSection": "Move {pt} {0} Up",
 			"passageToNextSection": "Move {pt} {0} Down",
-			"noteTitle": "Note title",
 			"pasting": "Pasting",
 			"propagate": "Propagate to all {0} in the {1}",
 			"publish": "Publish {0} {1}",