Repository navigation
TT-6465 let a note title use the desktop dictionary menu - #765
Merged
Merged
Conversation
gtryus
marked this pull request as draft
October 15, 2026 16:13
gtryus
force-pushed
the
TT-6465-note-title-dictionary
branch
from
October 19, 2026 19:43
7f5948b to
c2f7bba
Compare
gtryus
marked this pull request as ready for review
October 19, 2026 19:44
The title was static text, and the sheet menu took the right-click, so Add to Dictionary never appeared on a misspelled note title. Co-authored-by: Cursor <cursoragent@cursor.com>
gtryus
force-pushed
the
TT-6465-note-title-dictionary
branch
from
October 20, 2026 17:58
c2f7bba to
0180d58
Compare
gtryus
pushed a commit
that referenced
this pull request
Oct 22, 2026
) * chore: stop localizing the note title aria-label The note title field added in #765 used a new planSheet.noteTitle string only as an aria-label. Use a plain English label instead and remove the string from the XLIFF so translators have nothing extra to translate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: label the note title with the Title column header Use the existing scriptureTable.title string ("Title", the visible column header) as the note title aria-label instead of a hard-coded English one. Also keep develop's strings bundle and drop only noteTitle from it: regenerating from the committed XLIFF files lost newer Arabic and Tamil translations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: reuse visible label strings for aria labels Add guidance to the localization doc: an aria-label should reuse the string of the control's visible label rather than add a new XLIFF unit, so translators get no extra strings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: shorten the aria-label localization guidance Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
NoteTitleField.test.tsx: 2 passed