Skip to content

Fix LT-22525 (pass 2)#1020

Merged
AndyBlack merged 1 commit into
mainfrom
LT22525b
Jul 21, 2026
Merged

Fix LT-22525 (pass 2)#1020
AndyBlack merged 1 commit into
mainfrom
LT22525b

Conversation

@AndyBlack

@AndyBlack AndyBlack commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

When using the TonePars with FLEx utility and the data has one or more procltics or enclitics, one could get an empty/blank HVO value for the clitic with a resulting crash.

This has two fixes:

  1. A check for an empty HVO which is skipped like other data items that are not found in the database (in XAmpleParser.cs).
  2. For XAmple-produced input to TonePars, skip the Prt "category" as well as the W "category" in the ANA line (in ToneParsInvoker.cs).

While doing this, I happened to notice that there was a case of some code that was no longer needed now that this utility is part of FLEx. See MorpherAnaProducer.cs and XAmpleMorpherAnaProducer.cs.

Finally, I also realized that every segment listed in the UI could be processed. I had been blocking ones that did not have every word with an analysis. That is needed for PcPatr with FLEx, but not for TonePars with FLEx. See ToneParsFLExForm.cs.


This change is Reviewable

Change-Id: I3de2ed37bd6c47b7b60ae9e92540e3734386a0d1
@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   7m 7s ⏱️ - 3m 41s
4 306 tests ±0  4 233 ✅ ±0  73 💤 ±0  0 ❌ ±0 
4 315 runs  ±0  4 242 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit 1f05592. ± Comparison against base commit 9b7d537.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.99%. Comparing base (9b7d537) to head (1f05592).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Src/LexText/ParserCore/XAmpleParser.cs 0.00% 3 Missing and 1 partial ⚠️
...ies/pcpatrflex/ToneParsFLExDll/ToneParsFLExForm.cs 0.00% 1 Missing ⚠️
...ties/pcpatrflex/ToneParsFLExDll/ToneParsInvoker.cs 0.00% 0 Missing and 1 partial ⚠️
...trflex/ToneParsFLExDll/XAmpleMorpherAnaProducer.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   32.99%   32.99%           
=======================================
  Files        1202     1202           
  Lines      278209   278189   -20     
  Branches    37160    37158    -2     
=======================================
  Hits        91789    91789           
+ Misses     158563   158544   -19     
+ Partials    27857    27856    -1     
Files with missing lines Coverage Δ
...s/pcpatrflex/ToneParsFLExDll/MorpherAnaProducer.cs 0.00% <ø> (ø)
...ies/pcpatrflex/ToneParsFLExDll/ToneParsFLExForm.cs 0.00% <0.00%> (ø)
...ties/pcpatrflex/ToneParsFLExDll/ToneParsInvoker.cs 0.00% <0.00%> (ø)
...trflex/ToneParsFLExDll/XAmpleMorpherAnaProducer.cs 0.00% <0.00%> (ø)
Src/LexText/ParserCore/XAmpleParser.cs 58.40% <0.00%> (-0.68%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndyBlack
AndyBlack merged commit da7f604 into main Jul 21, 2026
6 checks passed
@AndyBlack
AndyBlack deleted the LT22525b branch July 21, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants