Conversation
Change-Id: I3de2ed37bd6c47b7b60ae9e92540e3734386a0d1
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 32.99% 32.99%
=======================================
Files 1202 1202
Lines 278209 278189 -20
Branches 37160 37158 -2
=======================================
Hits 91789 91789
+ Misses 158563 158544 -19
+ Partials 27857 27856 -1
🚀 New features to boost your workflow:
|
jtmaxwell3
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the TonePars with FLEx utility and the data has one or more procltics or enclitics, one could get an empty/blank HVO value for the clitic with a resulting crash.
This has two fixes:
While doing this, I happened to notice that there was a case of some code that was no longer needed now that this utility is part of FLEx. See MorpherAnaProducer.cs and XAmpleMorpherAnaProducer.cs.
Finally, I also realized that every segment listed in the UI could be processed. I had been blocking ones that did not have every word with an analysis. That is needed for PcPatr with FLEx, but not for TonePars with FLEx. See ToneParsFLExForm.cs.
This change is