Fix LT-22611: Allow Bulk Edit Inflection Features for affixes#1018
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 32.99% 32.98% -0.01%
==========================================
Files 1202 1202
Lines 278175 278248 +73
Branches 37152 37169 +17
==========================================
+ Hits 91781 91788 +7
- Misses 158543 158593 +50
- Partials 27851 27867 +16
🚀 New features to boost your workflow:
|
mark-sil
approved these changes
Jul 21, 2026
mark-sil
left a comment
Contributor
There was a problem hiding this comment.
@mark-sil reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22611. We can't just set the inflection features of the MSA since it may be shared with other lexical senses. So we make a copy of the MSA and set its inflection features. We then see whether there is an existing MSA that matches it. If there is, then we use it and delete the copy.
I added code for deleting newFsTarget if it was created by FillInBlanks and it isn't used elsewhere.
This change is