Cherrypicks for 9.3.10#1016
Merged
Merged
Conversation
The .NET 4.8 retarget changed the hash WCF uses in named-pipe names, so FLEx and FLEx Bridge (net462) could no longer find each other's endpoints and the "changes received" signal was silently lost. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
mark-sil
approved these changes
Jul 21, 2026
mark-sil
left a comment
Contributor
There was a problem hiding this comment.
@mark-sil reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on aror92).
* Fix LT-22630: Custom first vernacular fields defaulting to analysis The LT-22145 fix made StringSliceView.WsPending force DefaultAnalWs on every keystroke, so typing in custom fields configured for another writing system came out as analysis. WsPending now supplies a writing system only when the field is empty, using the ws configured for the slice and falling back to DefaultAnalWs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * LT-22630: Make ws chooser match data-entry ws in empty fields The chooser reads the selection's props, which fall back to the UI ws in an empty field even though typing uses the slice's configured ws. Set typing props on an insertion point in an empty field so the chooser and keyboard agree with what typing will produce. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Change-Id: I619bdc92b44e9925a821638b3920d2cb33ed3193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the cherrypicks to include in the final 9.3.10 build
This change is