Repository navigation
Remove lrn and spid from phone number lookup carrier response - #950
Draft
hey-august wants to merge 1 commit into
Draft
hey-august wants to merge 1 commit into
hey-august wants to merge 1 commit into
Conversation
They were removed in #670 and re-added by a later spec gap-closing change.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
lrnandspidproperties from the carrier lookup object in the phone number lookup response. They were removed in #670, then re-added by a later spec gap-closing change. This PR takes out only those two fields. The rest of that change stays.The
.tspsource and the regeneratedopenapi.yamlare committed together. The diff is 22 deletions: 8 incore.tspand 14 inopenapi.yaml.Type of Change
Related Issues
None. The request came from the team, not an issue.
Testing
Tested manually
yarn build:specssucceeds.A word-boundary, case-insensitive grep for
lrn|spidoverfern/andspecs/now finds no hits.No MDX was changed, so
yarn fern-md-checkwas not run. No nav or redirects were changed either, soyarn fern-checkwas not run.Checklist
Additional Notes
Removing these fields is the requester's decision. I did not check whether the platform still returns them. The fields are simply not documented.
Only
openapi.yamlis regenerated underfern/apis/. Thetsp-outputfiles had nolrnorspidreferences before or after the edit.Outside this PR: nothing found.