Repository navigation
Conversation
StreamedTests imports Combine without using it, which stops the test target compiling where Combine is absent. The AsyncLazySequence cancellation test returned while its Task was still awaiting an expectation; corelibs-XCTest reports that as an unwaited expectation, so the test is now async and awaits the task. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8cahEd4GfsHQ89sNrmP4p
Contributor
|
Closing as superseded by merged PR #74: #74. Both fixes are now on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two test-only changes, no library code touched:
Tests/AsyncSubjets/StreamedTests.swiftimportsCombinebut uses nothing from it; the import stops the test target compiling wherever Combine is absent. Removed.AsyncLazySequenceTests.test_AsyncLazySequence_returns_an_asyncSequence_that_finishes_when_task_is_cancelledis a synchronous test that returns while theTaskit started is stillawait fulfillment(of:)-ing an expectation. Apple's XCTest tolerates that; corelibs-XCTest reportsFailed due to unwaited expectation 'The task has been cancelled'. The test is nowasync, usesawait fulfillment(of:)for the first expectation and awaits the task before returning, so the assertion inside the task also runs before the test ends.Tests
Linux, Swift 6.4, x86_64, with #70 applied underneath (the library needs it to compile here), three consecutive runs:
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01T8cahEd4GfsHQ89sNrmP4p