Upgrade brace-expansion to address GHSA-3jxr-9vmj-r5cp - #17
Merged
Conversation
brace-expansion 1.1.15 is vulnerable to an exponential-time DoS via consecutive non-expanding brace groups (GHSA-3jxr-9vmj-r5cp, high). Patched in 1.1.16 for the 1.x line. `pnpm update brace-expansion` reached the patched version directly, so this is a lockfile-only change -- minimatch@3.1.5 already declares `brace-expansion: ^1.1.7`, which 1.1.16 satisfies. No override needed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alert #63.
What
brace-expansion1.1.15 → 1.1.16. Lockfile-only change — nopackage.jsonorpnpm-workspace.yamledits, no overrides.pnpm update brace-expansionreached the patched version on its own: the only copy in the tree comes fromminimatch@3.1.5, which declaresbrace-expansion: ^1.1.7, and 1.1.16 satisfies that range. Steps 2–4 of the usual escalation (parent upgrade, overrides) were not needed.1.1.16 was published 2026-07-08, so it is already past the repo's 14-day
minimumReleaseAge. The age policy was not touched.Advisories
< 1.1.16)<= 5.0.7)Why alert austenstone#64 is not addressed here
GHSA-mh99-v99m-4gvg is only patched in 5.0.8. There is no patched release on the 1.x or 2.x lines: the upstream backport PRs (juliangruber/brace-expansion#129 and austenstone#130) are still open, and 1.1.16 verifiably lacks the length bound — the
EXPANSION_MAX/EXPANSION_MAX_LENGTHguards exist only in the 5.x source.The repo has exactly one copy of
brace-expansion, on the 1.x line viaminimatch@3.1.5. There is nothing on the 5.x line to bump, so no part of alert austenstone#64 is fixable today.An override forcing the 1.x copy to 5.0.8 is not a viable stopgap either. 5.x changed the export shape — its CommonJS build does
exports.expand = expand(a named export), whereasminimatch@3.xdoesrequire('brace-expansion')and calls the module object directly. Forcing 5.0.8 would fail at call time withexpand is not a function. It also raises the engine floor to Node20 || >=22.The disposition of alert austenstone#64 is a separate decision and is deliberately left open.
Note on CI
pnpm testfails on this branch, but it fails identically on a clean tree (pre-existing TypeScript errors in__tests__/main.test.ts: a missing@jest/globalstype declaration and stale kebab-case keys in theInputfixture). Not caused by this change.