Added Wayland support via interactive or non-interactive call by Photon89 · Pull Request #818 · shutter-project/shutter

Photon89 · 2026-05-25T15:13:41Z

This PR is based on #817. However, it now tries to use an non-interactive target as defined in flatpak/xdg-desktop-portal#1981. If a target is not yet implemented by a DE, it falls back to an interactive call which shows the DE's interactive mode chooser. As soon as a DE implements the non-interactive targets, Shutter should pick them up and not call the interactive mode chooser any more. Also, the full screen capture is unaffected.

Tested for various DEs:

For Gnome the interactive mode chooser works quite well. Limitations: The user needs to choose the capture mode again (after having chosen it in Shutter). Filenames are still set to "unknown".
For KDE the interactive mode chooser seems to offer no selection mode. Also there seems to be no window selection mode, only capturing the active window is possible, which is the mode chooser dialog itself though. So in KDE this PR is basically useless.
For Cinnamon the interactive mode chooser is not really implemented and always falls back to full screen capture.

Tested non-interactive targets:

For Cinnamon we are waiting for linuxmint/cinnamon@b780321697ddc1c137557 to be released. But if substituting cinnamon-screenshot with gnome-screenshot, getting screenshot via xdg-desktop-portal-xapp works. The only thing broken is a window chooser (only gets active window instead). Created a feature request for this: https://github.com/orgs/linuxmint/discussions/1548
For Xfce xdg-desktop-portal-xapp is used so far. I commented here: https://gitlab.xfce.org/xfce/xfce4-session/-/work_items/159

mvivarelli · 2026-05-27T08:09:24Z

Hi Michael,

I'm Maurizio. I wrote the gnome-screenshot hack for Ubuntu 24.04.

I was looking for a solution to extend Shutter's life on Ubuntu 26.04, where gnome-screenshot no longer works.

I tested your PR just now, and it seems to be a temporary but nevertheless pretty usable solution.

Thanks,

Maurizio

Photon89 · 2026-05-27T10:29:44Z

Hi Maurizio,

great, thanks for testing! As Gnome hasn't implemented non-interactive targets so far, Shutter has to fall back to the interactive mode chooser. That's actually worse than what you have implemented in your PR. And the sad news is that the non-interactive calls will be supposedly forwarded to gnome-screenshot once they have been implemented, so yeah... At least that's what happens in Cinnamon so far.

Let's hope that this will be good enough for potential users. I guess, we've lost many of them due to lacking Wayland support...

DarthGandalf · 2026-08-14T12:47:17Z

+                $supported_targets{'1'} = 1 if ($targets_raw & 1);
+                $supported_targets{'2'} = 1 if ($targets_raw & 2);
+                $supported_targets{'4'} = 1 if ($targets_raw & 4);
+                $supported_targets{'8'} = 1 if ($targets_raw & 8);


in the non-raw version use names instead of digits? Or reverse, even keep it as raw number and check & directly?

Good idea, I'll rework it to use names!

Done in latest commit!

I noticed that the names cannot be directly passed to xdg-portal, so we need to convert them back to numbers in Wayland.pm before they are passed to xdg-portal. Maybe it's actually better to keep the numbers?

I'm fine with numbers, but then you don't need distinguishing between "raw" numbers and "non-raw" numbers

Please check the latest commit, is this better now?

Yeah, that looks simpler. Added a comment about a comment

DarthGandalf · 2026-08-14T12:52:42Z

 sub xdg_portal {
 	my $screenshooter = shift;
+	my $interactive = shift;
+	my $target = shift;


what does target mean? some comments would help

Added comments!

DarthGandalf · 2026-08-14T12:59:21Z

+			# For some period of time desktops won't support non-interactive targets, we need to deal with it.
+			my $target;
+			my $interactive;
+			# For fullscreen capture just use plain xdg_portal


wouldn't that show the interactive prompt even on supporting compositors?

Do you mean the full screen case? I'm not sure, that's the very early Wayland.pm which you wrote, I haven't looked inside tbh. For the moment, I didn't want to change anything with full screen capture because I assumed that it works well already. Do you know what the status actually is with full screen capture?

what I did is a horrible hack :)

the problem with "my" method is that depending on compositor it will either show the prompt, or it won't, and shutter cannot detect that. This spawned the discussion in the first place.

I randomly put it to "fullscreen" button of shutter just because I needed to put it somewhere. It could as well be a new button which invokes the compositor-specific prompt (or even does screenshot without prompt, we never know); but depending on what users selects in that prompt in may not in fact be fullscreen.

If the specific implementation of the portal reports that it supports promptless fullscreen target, we should use that

If the specific implementation of the portal reports that it supports promptless fullscreen target, we should use that

I see, will do! :)

DarthGandalf · 2026-08-14T15:14:44Z

I cannot find where you commented about #828 but yes, these PRs do conflict. But adding non-interactive fullscreen screenshot should help with per-monitor screenshot of that PR too. And non-interactive screenshot should be repeatable too, not just ones which happen to be interactive (or not) depending on DE

Photon89 · 2026-08-14T15:27:54Z

I cannot find where you commented about #828 but yes, these PRs do conflict. But adding non-interactive fullscreen screenshot should help with per-monitor screenshot of that PR too. And non-interactive screenshot should be repeatable too, not just ones which happen to be interactive (or not) depending on DE

Yeah, my comment was wrong so I deleted it, but the conflict is nevertheless there. I will try to figure out how to solve it.

Photon89 · 2026-08-14T19:24:08Z

Is there anything to improve here besides of compatibility with #828?

DarthGandalf · 2026-08-14T19:33:33Z

I can't easily test it, as I don't use wayland, but if you tested it, fine. Yeah, #828 is probably the only thing

Photon89 · 2026-08-14T19:35:53Z

I did some testing in VMs before the latest changes. Will now also test full screen and report back.

DarthGandalf · 2026-08-14T19:36:05Z

btw, we need to get some way to test all the wayland stuff in CI

no clue if somethig like Xvfb exists

Photon89 · 2026-08-15T08:26:30Z

Absolutely, could you look into it when time permits?

I also noticed that the file name in Wayland is still just unknown_%nn.png, we can at least make it depend on the chosen mode if Wayland refuses to pass the window's name.

vadi2 · 2026-08-15T08:37:47Z

xvfb does work in CI, I use it. Just using xvfb-run in a script works.

DarthGandalf · 2026-08-15T08:39:59Z

@vadi2 That's what unit tests are doing here now. But it's X, not wayland. Or can wayland work on top of xvfb?

vadi2 · 2026-08-15T08:45:36Z

Ahh, my bad. I haven't tried xvfb, but Claude was able to spin up a new gnome shell in Wayland for testing for me previously.

Photon89 · 2026-08-15T11:07:28Z

So I implemented generic file names for Wayland capture. Since they cannot be acquired from xdg-portal, they are taken directly from the capture mode and can be "Workspaces", "Window" or "Selection w x h". Of course, specific window names won't work, and also no workspace numbers.

I'm not sure why it is called "Workspaces" instead of just "Workspace", but it was this way in X11 already (what happens when you just choose the "full" capture mode. On my machine using Compiz, you just get the currently active workspace when using "full", so it is weird to be called "Workspaces". But this is the string which gettext knows, so I kept it this way.

I now tested in Gnome and KDE. In both cases there is currently only the interactive API available.

In Gnome (Fedora latest, should be Gnome 50) you have once more choose the mode that you actually intend to use, but at least all three modes are supported (full screen, window, selection) and work well.

In KDE (tested in 6.2.5 and 6.6.5) you also have to once more choose the mode but, making things worse, there is no selection mode, not even interactively.

I think, currently it is a better UX to fall back to the "hackish" full screen capture, because most DEs don't support it via non-interactive capture so far. What do you think?

DarthGandalf · 2026-08-15T11:42:04Z

I think, currently it is a better UX to fall back to the "hackish" full screen capture, because most DEs don't support it via non-interactive capture so far. What do you think?

as fallback, sure.

…upport

Photon89 · 2026-08-15T13:55:26Z

Okay, done, so we at least don't get a downgrade by this PR.

Ready to merge once the merge conflicts are sorted out. Question is, which PR we merge first. I looked into the conflicts and they are actually not so bad. One conflict in Wayland.pm and three one line conflicts in the main shutter file.

Added Wayland support via interactive or non-interactive call

c96b2f2

Photon89 requested a review from DarthGandalf May 25, 2026 15:23

Fixed file permissions

bb3b2d4

Photon89 mentioned this pull request May 25, 2026

The Status & Future of Shutter #662

Open

Photon89 commented May 25, 2026

View reviewed changes

Comment thread bin/shutter Outdated

Photon89 added 3 commits May 26, 2026 08:28

Fixed getting available portal targets if target property undefined

c61459b

Fix retrieving ActiveTargets from portal

ae11a3d

Update warning message

5338d99

vadi2 approved these changes May 27, 2026

View reviewed changes

Photon89 added 3 commits August 5, 2026 10:41

Disable settings in environments where they are unnecessary

5b05ecc

Disable further settings in environments where they are unnecessary

07ae64b

Fixed default value for include_cursor

b42c47c

Photon89 linked an issue Aug 9, 2026 that may be closed by this pull request

Selection button inactive (was: Shutter does not work in Wayland) #187

Open

DarthGandalf reviewed Aug 14, 2026

View reviewed changes

Photon89 added 2 commits August 14, 2026 16:48

Use names instead of numerals for targets

c7529cf

Use proper xdg-portal call for full screen capture; added comments

daca43f

DarthGandalf mentioned this pull request Aug 14, 2026

wayland: per-monitor screenshot capture + redoshot support #828

Open

Convert back to numerals in Wayland.pm

b0e3dd6

Reverted to numerical target values

8d48014

Photon89 added 2 commits August 15, 2026 11:58

Added capture mode dependent file names on Wayland

8602267

Fix error if cannot be retrieved from xdg-portal

f0ec8f8

Fall back to simple full screen for DE without non-interactive call s…

ccc9998

…upport

Uh oh!

Uh oh!

Conversation

Photon89 commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mvivarelli commented May 27, 2026

Uh oh!

Photon89 commented May 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarthGandalf commented Aug 14, 2026

Uh oh!

Photon89 commented Aug 14, 2026

Uh oh!

Photon89 commented Aug 14, 2026

Uh oh!

DarthGandalf commented Aug 14, 2026

Uh oh!

Photon89 commented Aug 14, 2026

Uh oh!

DarthGandalf commented Aug 14, 2026

Uh oh!

Photon89 commented Aug 15, 2026

Uh oh!

vadi2 commented Aug 15, 2026

Uh oh!

DarthGandalf commented Aug 15, 2026

Uh oh!

vadi2 commented Aug 15, 2026

Uh oh!

Photon89 commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DarthGandalf commented Aug 15, 2026

Uh oh!

Photon89 commented Aug 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Photon89 commented May 25, 2026 •

edited

Loading

Photon89 commented Aug 15, 2026 •

edited

Loading