Repository navigation
Fix 401 on Check for updates by skipping the empty Authorization header - #1
Open
shrenixcodes wants to merge 1 commit into
Open
shrenixcodes wants to merge 1 commit into
shrenixcodes wants to merge 1 commit into
Conversation
The update check calls the releases API anonymously with an empty token, but the header was always sent as "Bearer " with nothing after it, which GitHub rejects with 401. Only send the header when a token is present. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
UreqHttp::apiincrates/core/src/github.rsnow adds theAuthorizationheader only when a token is present. Calls with an empty token go out as anonymous requests.Why
The update check (
updater::check_for_update) callsGET /repos/{repo}/releases/latestwith an empty token. The header was still sent asAuthorization: Bearerwith nothing after it, and GitHub rejects that with 401. In Settings → Application Updates this showed up as:Checked with curl against
shrenixcodes/RustGit:Authorization: Bearer→ 401Reviewer notes
cargo test -p rustgit-corepasses. Not yet tried in a rebuilt desktop app.🤖 Generated with Claude Code