Describe how billable units are counted and bounded - #135
Closed
dazzatronus wants to merge 1 commit into
Closed
Conversation
dazzatronus
force-pushed
the
derk/eng-903-add-units-bounds
branch
from
September 1, 2026 01:12
8de51d4 to
13a58bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The models endpoint returns
unitsandbounds, but the schema never described them, sonobody reading the spec can work out what a generation costs. A 61 second music track works
out to 5.08 credits when we actually charge 10, because the rate is per minute and a part
minute rounds up.
This also drops the line saying there is no formula to evaluate, which was never true.
Both properties are optional and nothing existing changes. The
tieredBytype is wrong aswell, but that one changes a contract we have already shipped, so it goes separately.
Verify:
pnpm bundle && pnpm build && pnpm test && pnpm test:smoke, 71 pass.https://linear.app/shotstack/issue/ENG-903