Skip to content

SG-44442 Fix published files name search for flowam - #156

Merged
carlos-villavicencio-adsk merged 1 commit into
masterfrom
ticket/SG-44442
Jul 28, 2026
Merged

SG-44442 Fix published files name search for flowam#156
carlos-villavicencio-adsk merged 1 commit into
masterfrom
ticket/SG-44442

Conversation

@carlos-villavicencio-adsk

Copy link
Copy Markdown
Contributor

This pull request refines the filtering logic in proxymodel_latestpublish.py to ensure that search filtering is always applied before type filtering. This change improves the accuracy and predictability of the filter behavior, especially when both search and type filters are used.

Filtering logic improvements:

  • The search filter is now applied before checking for type filters, ensuring that search results are always respected regardless of the type filter state.
  • If the search filter is set but the item's searchable field is missing or empty, the item is now correctly excluded from the results.
  • The code clarifies that when no type filter is active (_valid_type_ids is None), all items passing the search filter are accepted.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.27%. Comparing base (1a00055) to head (614f38e).

Files with missing lines Patch % Lines
python/tk_multi_loader/proxymodel_latestpublish.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   18.28%   18.27%   -0.02%     
==========================================
  Files          32       32              
  Lines        3074     3076       +2     
==========================================
  Hits          562      562              
- Misses       2512     2514       +2     
Flag Coverage Δ
Linux 18.27% <0.00%> (-0.02%) ⬇️
Python-3.10 18.27% <0.00%> (-0.02%) ⬇️
Python-3.11 18.27% <0.00%> (-0.02%) ⬇️
Python-3.13 18.27% <0.00%> (-0.02%) ⬇️
Python-3.9 18.27% <0.00%> (-0.02%) ⬇️
Windows 18.27% <0.00%> (-0.02%) ⬇️
macOS 18.27% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chenm1adsk chenm1adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlos-villavicencio-adsk
carlos-villavicencio-adsk merged commit b8402aa into master Jul 28, 2026
26 of 27 checks passed
@carlos-villavicencio-adsk
carlos-villavicencio-adsk deleted the ticket/SG-44442 branch July 28, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants