SG-43798 / SG-42460 Bump vendored tk-core to v0.24.0 and add minimum_python_version - #159
Open
stevelittlefish wants to merge 3 commits into
Open
SG-43798 / SG-42460 Bump vendored tk-core to v0.24.0 and add minimum_python_version#159stevelittlefish wants to merge 3 commits into
stevelittlefish wants to merge 3 commits into
Conversation
Runs tk_core_update.sh v0.23.10 to vendor the tk-core release that removes Python 3.7 support (SG-43667/#1107). This brings the version guard in python/tk-core/python/tank/__init__.py from a 3.7 hard-block to 3.9, and removes the vendored requirements/3.7/ directory. Note: v0.23.10 is currently a GitHub pre-release (QA in progress). tk_core_update.sh clones directly off the git tag and doesn't care about that flag, so this is safe to prep now, but this branch shouldn't be released until tk-core is confirmed/promoted. Scope intentionally excludes adding minimum_python_version to the top-level info.yml - that's tracked separately in SG-42460, which has its own history of breaking auto-update and needs its own careful validation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 10.30% 10.30%
=======================================
Files 13 13
Lines 582 582
=======================================
Hits 60 60
Misses 522 522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julien-lang
reviewed
Jul 20, 2026
julien-lang
left a comment
julien-lang
left a comment
Member
There was a problem hiding this comment.
Looks good but I don't see the changes from python-api?
Author
Does this need to be resolved now? If so I can do another tk-core release but it's time consuming. |
Contributor
It depends of the purpose of this release. If it's about releasing the 3.7 end of support, I believe we should include python-api. |
Supersedes the v0.23.10 bump in this branch. v0.24.0 adds tk-core#1123 (shotgun_api3 3.10.3, itself a git-tag pin since python-api isn't on PyPI yet) and #1118 (unzip long paths fix) on top of everything already in v0.23.10 (Python 3.9 version guard, requirements/3.7/ removal). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
stevelittlefish
changed the title
Sets minimum_python_version: "3.9", matching the guard already vendored from tk-core. This exact field was added by PR #148, then reverted twice (#151/#152) after QA found the auto-update mechanism blocking even on compatible (>=3.9) installs. The code presumed to fix that (SG-40996, tk-core c7eb43ed) has been unchanged since before that failure, so this needs a fresh pre-release + App Store QA-mode validation before promoting, same as the original PR #148 process - not a plain merge-and-release. Supersedes the stale draft in #158. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
stevelittlefish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs
tk_core_update.sh v0.24.0to vendor the latest tk-core release, and addsminimum_python_version: "3.9"to the top-levelinfo.yml(SG-42460).tk-core bump:
python/tk-core/python/tank/__init__.pyfrom a Python 3.7 hard-block to 3.9 (SG-43667 / tk-core#1107, first vendored at v0.23.10).requirements/3.7/directory.minimum_python_version (SG-42460):
minimum_python_version: "3.9"to the rootinfo.yml, matching the guard now vendored from tk-core.v2.5.4. The code presumed to fix this (SG-40996, tk-corec7eb43ed—_check_minimum_python_version/_find_compatible_cached_versioninappstore.py/base.py) has had no logic changes since before that failure, so this needs a fresh pre-release and a re-run of the same App Store QA-mode validation PR SG-40996 The minimum_python_version has been set to 3.9. #148 originally did, before promoting past pre-release. Do not treat merging this PR as sufficient on its own.Scope
Intentionally does not touch anything else in
minimum_python_versionhandling beyond theinfo.ymlfield itself — no changes toupgrade_startup.py'scheck_version_constraints()(which doesn't check this field at all) or toappstore.py's compatibility logic.Test plan
python/tk-core/info.ymlnow readsversion: "v0.24.0"andcommit_idmatches the v0.24.0 tag commitpython/tk-core/python/tank/__init__.pyguard still readssys.version_info < (3, 9)python/tk-core/requirements/3.7/is still gonePart of epic SG-36195.
🤖 Generated with Claude Code