Skip to content

fix: reconcile package and CLI template drift (batch 1) - #63

Merged
Shewart merged 8 commits into
mainfrom
fix/template-drift-1
Oct 17, 2026
Merged

Shewart merged 8 commits into
mainfrom
fix/template-drift-1

Conversation

@Shewart

@Shewart Shewart commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Part of #52. Eight components where one copy was plainly wrong or behind the other.

Package:

  • Label: For was accepted but never rendered as for.
  • FileUpload: the icon needed the Material Symbols font, which the package does not ship. Now an inline SVG, as in the CLI template.
  • Sheet: the close button was missing when only Description was set.
  • Sheet, Drawer, SheetContent, DrawerContent: clicks inside the panel reached parent click handlers.

CLI templates:

  • CarouselItem: divide by zero when TotalSlides is 0.
  • SidebarMenuButton: collapsed-icon styling from the package.
  • Menubar: border follows the theme colour.
  • ThemeToggle: class building matches the package.

Also adds a markup comparison to TemplateSyncTests for these components (the existing test only compares @code blocks), regenerates the class safelist, and corrects the roadmap: the Select, ContextMenu, NavigationMenu and Carousel parts already have CLI templates.

180 of 217 package components now match their templates. Build has 0 warnings, 349 tests pass. Not checked in a browser.

Copilot AI balanced review requested due to automatic review settings October 17, 2026 20:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Shewart
Shewart merged commit 4f7e15e into main Oct 17, 2026
1 check passed
@Shewart
Shewart deleted the fix/template-drift-1 branch October 17, 2026 21:35
Shewart added a commit that referenced this pull request Oct 20, 2026
Release notes and version references for 0.4.0-alpha.3. The first
release published with NuGet Trusted Publishing (#71).

**In this release** (already on main)
- #69: a component's `Class` overrides its own conflicting classes
(`Shell.Cn` merges like tailwind-merge)
- #64: Dialog, AlertDialog, Sheet and Drawer keep keyboard focus inside
and return it on close
- #70: `add` never downgrades a NuGet package the project already
references
- #71: `init` supports Razor class libraries, plus a guide; release
workflow on Trusted Publishing
- #63, #65, #66, #68: CLI templates reconciled with the package
(RadioGroup, ScrollArea, DatePicker, TimePicker, Pagination, Toast,
Skeleton, Sheet/Drawer and more)

**Breaking for CLI template users** (after `shellui update`, all in the
notes with upgrade steps): `Input.InputVariant` becomes `InputVariant`
(new `input-variants` template); Stepper parts read `ActiveStep` instead
of taking `CurrentStep`; `ScrollArea` drops its `scrollbar-*` classes.
`update` installs the new templates automatically.

**This PR**
- `Directory.Build.props` suffix `alpha.3`; README, VERSIONING_STRATEGY,
CLI_INSTALLATION, CLI_SYNTAX, FAQ, QUICKSTART and the version fallbacks
move to `0.4.0-alpha.3`
- `docs/RELEASE_NOTES.md`: the 0.4.0-alpha.3 section;
`scripts/extract-release-notes.sh 0.4.0-alpha.3` extracts it

**Release checks**
- Release build has 0 warnings, and all 484 tests pass
- An app set up with the released 0.4.0-alpha.2 CLI, updated with the
packed alpha.3 CLI: 36 components updated, `input-variants`,
`textarea-variants` and `stepper-models` installed, builds 0/0
- CLI templates in a browser: RadioGroup selects (disabled items
ignored), ScrollArea scrolls, Pagination `@bind-CurrentPage`, Stepper
Next, DatePicker puts 1 October 2026 under Thursday, TimePicker
`Step="15"` lists 00/15/30/45, `Class="px-8 bg-destructive"` replaces
the button's own `px-4 bg-primary`, `InputVariant.Error` applies
- Focus trap with real key presses (templates and package): Tab cycles
inside the dialog and wraps, Shift+Tab goes back, Escape closes and
returns focus to the trigger
- All 93 direct targets together in `my-app` build 0/0 on net8.0, net9.0
and net10.0 (244 registry entries)
- The packed `ShellUI.Components` in a browser: the class override,
TimePicker, dark mode with `color-scheme`, Popover Escape, Command
`Action`, the dialog focus trap; no console errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants