Skip to content

fix: Move internal-only time package under internal (#62) - #121

Draft
shamaton wants to merge 1 commit into
mainfrom
fix/issue-62
Draft

fix: Move internal-only time package under internal (#62)#121
shamaton wants to merge 1 commit into
mainfrom
fix/issue-62

Conversation

@shamaton

@shamaton shamaton commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move the  v3/time  package to  internal/time  to make clear it's a non-public implementation detail
  • Previously public  SetDecodedAsLocal  remains reachable via existing  msgpack.SetDecodedTimeAsUTC/Local 

Background / Motivation

  •  github.com/shamaton/msgpack/v3/time  was only used internally for timestamp ext encode/decode but had accidentally been exposed as a public package
  • Code search and pkg.go.dev checks found no external importers

Changes

  • Move files under  time/  to  internal/time/ 
  • Update import paths from  v3/time  to  v3/internal/time  across the codebase

Notes

@github-actions github-actions Bot added the type: bug Confirmed or likely defect label Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (da1826f) to head (de19ef3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          74       74           
  Lines        7017     7017           
=======================================
  Hits         6520     6520           
  Misses        311      311           
  Partials      186      186           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Confirmed or likely defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant