Skip to content

feat: add access log toggle - #344

Merged
qiuyuzhou merged 1 commit into
masterfrom
feat/access-log-toggle
Oct 23, 2026
Merged

qiuyuzhou merged 1 commit into
masterfrom
feat/access-log-toggle

Conversation

@qiuyuzhou

Copy link
Copy Markdown
Collaborator

Summary

Access = Console by default
Access = None if CLI -disableAccessLog or SIP003 disableAccessLog is present
Error = None if loglevel is none

SIP003 accepts disableAccessLog as a bare key. Values are rejected. With SIP003 endpoints present, malformed option syntax returns a startup configuration error.

Evidence

  • Before: Access logs always went to Console.
    After: Either opt-out can disable Access output while the default remains unchanged.
  • Review found no actionable defects. The test suite did not complete because the sandbox blocked local socket binds, so runtime verification remains incomplete.

Merge Danger

Door: two-way

Blast Radius: low

Valid configurations keep the existing behavior. Invalid SIP003 option syntax now produces a configuration error.

@qiuyuzhou
qiuyuzhou merged commit 7466d1f into master Oct 23, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant