Skip to content

Choose whether a deploy serves its domain over HTTPS - #98

Merged
liamdevss merged 1 commit into
mainfrom
https-choice
Nov 16, 2026
Merged

liamdevss merged 1 commit into
mainfrom
https-choice

Conversation

@liamdevss

Copy link
Copy Markdown
Contributor

For #97, with serveroshq/daemon#23 (which fixes the actual bug: nginx and Apache couldn't read certbot's challenge folder, so they never got a certificate).

The deploy dialog gets a Serve over HTTPS tickbox under the domain, on by default. With it on, the hint says the chosen proxy gets a certificate and sends HTTP to HTTPS. With it off, it says the site is plain HTTP with no certificate, for a CDN or proxy in front that does HTTPS.

  • A deploy with a domain sends https when the dialog (or the API or MCP) says. Leaving it out lets the daemon keep what the app had, which is HTTPS for a new one.
  • Gated on daemon.https_choice_since (0.1.1-pre.41). The dialog only shows the tickbox from that version. Turning HTTPS off on an older daemon is refused with "too old to serve a domain without HTTPS", and asking for HTTPS is always fine.
  • The deploy result's address is http:// when HTTPS is off, so the done step doesn't promise a certificate.
  • deploy_from_git and deploy_template (MCP) take https too.
  • The wildcard hint only promises per-subdomain certificates for Caddy with HTTPS on.
  • Strings in es, de and hi.

Checked

  • New HttpsChoiceTest (5 tests), and ServiceTemplateTest updated for the new field.
  • Full tests/ suite: three failures that also fail without this change in my local setup (AuditCoverage, SyncDaemonReleases, and a trial-celebration test that passes on its own).
  • Pint, PHPStan on the changed files, vp check, vue-tsc.

@liamdevss
liamdevss requested a review from a team as a code owner November 16, 2026 22:01
@liamdevss
liamdevss merged commit f3795b3 into main Nov 16, 2026
5 of 7 checks passed
@liamdevss
liamdevss deleted the https-choice branch November 16, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant