Repository navigation
Choose whether a deploy serves its domain over HTTPS - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #97, with serveroshq/daemon#23 (which fixes the actual bug: nginx and Apache couldn't read certbot's challenge folder, so they never got a certificate).
The deploy dialog gets a Serve over HTTPS tickbox under the domain, on by default. With it on, the hint says the chosen proxy gets a certificate and sends HTTP to HTTPS. With it off, it says the site is plain HTTP with no certificate, for a CDN or proxy in front that does HTTPS.
httpswhen the dialog (or the API or MCP) says. Leaving it out lets the daemon keep what the app had, which is HTTPS for a new one.daemon.https_choice_since(0.1.1-pre.41). The dialog only shows the tickbox from that version. Turning HTTPS off on an older daemon is refused with "too old to serve a domain without HTTPS", and asking for HTTPS is always fine.http://when HTTPS is off, so the done step doesn't promise a certificate.deploy_from_gitanddeploy_template(MCP) takehttpstoo.Checked
HttpsChoiceTest(5 tests), andServiceTemplateTestupdated for the new field.tests/suite: three failures that also fail without this change in my local setup (AuditCoverage, SyncDaemonReleases, and a trial-celebration test that passes on its own).vp check,vue-tsc.