Repository navigation
Conversation
liamdevss
requested changes
Nov 16, 2026
liamdevss
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this is a big improvement and mostly ready. It merges cleanly with main (including #94), vue-tsc is clean and the targeted tests pass. Two things before it goes in:
resources/js/app.ts:93-96: don'tpreventDefault()every InertianetworkError. In Inertia 3.8 that event fires for any failed visit, not just network failures. Preventing the default skipsonPrefetchError, so a failed prefetch stays "in flight" forever: theprefetchlinks inUserMenuContent.vueandAccountMenu.vuestop working until a full reload (and just hovering them on a flaky connection pops the toast). It also stops non-network errors, like a chunk that fails to load after a deploy, from reaching Sentry. Please drop thepreventDefault()and only toast whenisNetworkError(event.detail.error)is true.WorkflowEngine::readable(): anyRuntimeExceptionmessage becomes the step's message, and that goes into theworkflow.failedalert (Slack, email, webhook). phpredis'sRedisExceptionis aRuntimeException, so "read error on connection to 10.x.x.x:6379" could reach a customer's Slack, and the same for other frameworkUnexpectedValueException/OutOfBoundsExceptiontypes. Please check for exactlyRuntimeException::classor use a dedicated user-facing exception class.
Optional, since the gap was there before: app/Mcp/Tools/Service/ServiceView.php:128-136 still returns error.output_tail for private console jobs through Present::job. An Arr::except($out['error'], ['output_tail']) there would make the "console output stays private" point true for MCP and Ask AI too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When something goes wrong, the panel now says what failed, why, and what to do next, instead of a bare "Failed", "Something went wrong" or the browser's "Failed to fetch".
The dashboard
One shared helper,
resources/js/lib/errors.ts, used in about 35 screens:error, the API's{error: {message, next_step}}andmessageare read in that order. Laravel's stock texts ("Server Error", "CSRF token mismatch.") and internals ("No query results for model [App\Models\…]") are replaced by plain ones per status: signed out, page open too long, no permission, too many tries, panel restarting.TypeErrororSyntaxErrorfrom the page shows a short fallback, not JavaScript internals. Cancelled requests don't show their URL.Screens covered include connecting a machine (its Advanced tab no longer spins forever when its options can't load), the welcome page, the setup wizard, deploys, the service page, firewall, tunnel, disk usage, files, database, console, updates and rollouts, job log, clone, app variables, alerts, logs, API and MCP keys, two-factor setup, Ask AI and the status page. Background polls stay quiet on purpose.
The server
DeployFailure::general()). Job answers in the API and MCP carry it asexplanation.error.output_tail. A console command's own output isn't explained as a machine problem.Translations
New strings in Spanish, German and Hindi; 14 strings nothing uses any more removed.
Tested
tests/Unit/DeployFailureTest.phpandtests/Feature/MachineServiceTest.phpfail without the change),tests/js/errors.test.mjswithnode --test, Pint, PHPStan, vp check and vue-tsc.Before merging
explanationfield.tests/jsisn't run by CI.Fixes #86
Most of this was generated by Claude.