Repository navigation
Check the new proxy stays up before letting the old one go - #22
Merged
Merged
Conversation
…running and answering on port 80 before letting the old one go, and puts the old one back if not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20, found by testing a switch on a real systemd machine.
When the new proxy started and then fell over a moment later (in the test: something else had port 443, so Traefik exited right after
systemctl enable --nowreturned), the switch counted it as done. The old proxy was already stopped and was then disabled, so every site went offline.Now, after writing the sites, the switch waits 4 seconds and checks that the new proxy's unit is still active and that port 80 accepts a connection. If not, it fails with the unit's journal, removes the new site files, stops and disables the new proxy (so it doesn't fight for the ports on the next boot), and starts the old one again.
Checked on Ubuntu 24.04 with systemd (a privileged container):
cargo fmt,cargo clippy --workspace --all-targets -D warnings, and the daemon-deploy tests.