Repository navigation
Add -timeout flag to increase client timeout - #15
Merged
Merged
Conversation
strzibny
requested review from
adarshdigievo,
bradenr402,
dsojevic,
ilyazub,
peterberkenbosch and
pulkitchowdry
October 8, 2026 11:03
adarshdigievo
approved these changes
Oct 9, 2026
hilmanski
reviewed
Oct 9, 2026
hilmanski
left a comment
hilmanski
left a comment
There was a problem hiding this comment.
Late review on the README addition
| ``` | ||
| Quote the expression with single quotes in bash/zsh to avoid shell interpretation of `$`, `|`, and `"`. | ||
| - `--api-key <key>` — Override API key (takes priority over environment and config file) | ||
| - `--timeout <seconds>` — HTTP request timeout (default `60`, env: `SERPAPI_TIMEOUT`). Use `0` to wait indefinitely. Slow engines such as `google_ai_mode`, or searches with `no_cache=true`, can take longer than the default; raise this if you see a `network_error` mentioning `Client.Timeout exceeded`. Note that a timed-out search may still complete on SerpApi's side and be billed and retrievable with `serpapi archive <search-id>`. |
There was a problem hiding this comment.
Why do we consider google_ai_mode as a slow engine?
or searches with
no_cache=true, can take longer than the default
This is also a bit confusing. All of the searches have no_cache=true by default.
ilyazub
added a commit
that referenced
this pull request
Oct 13, 2026
v0.2.3 shipped on 2026-03-31; #7, #9, #15 and #17 merged after it and none reached users, because a release waited for someone to push a tag. Now, after both test legs and the live e2e pass on main, the tag job tags the commit with the next version and calls release.yml: a patch, or what the PR's release:minor or release:major label asks for. A release:skip label, or a merge where nothing that ships changed since the latest release, releases nothing. Outside pull requests a skipped live test fails CI, a published tag is never reused, a commit older than the latest release is never tagged, and runs on main go one at a time. A Release preview check tells each PR what merging releases. Dry run on this history: this branch with release:minor gives v0.3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ilyazub
added a commit
that referenced
this pull request
Oct 13, 2026
Only the merged pull request's label set the bump, so a release:major merge whose run failed was released by the next, unlabeled merge as a patch. Now a release:minor or release:major label on any pull request merged since the latest release counts; release:skip still applies only to the merge being released. On this history the lookup asks for 7 commits' pull requests, #2 to #15, none labeled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should let people handle their timeout considerations. This does not change the server timeout and/or if request finishes, but let people manage their expectations. I am also changing the default to 60s which is serpapi-golang's default.