feat(core): Add model support to core - #387
Open
misonijnik wants to merge 2 commits into
Open
Conversation
Saloed
requested changes
Aug 28, 2026
misonijnik
changed the title
Saloed
requested changes
Sep 1, 2026
| } | ||
|
|
||
| check(program != null) { "Unexpected IR build issue" } | ||
| val mergedProgram = GoModelMerger().merge(program, models) |
Contributor
There was a problem hiding this comment.
I don't like the model merge implementation, that works on the raw (serialized) IR layer. Currently, it rewrites the program raw IR, so we can never see the real program. Let's do it similar to the jvm: build GoIr for the program and for the models, then apply rewrites lazily, during GoIR lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.