Skip to content

fix: escalate Claude companion network calls#82

Open
behruznassre wants to merge 1 commit into
sendbird:mainfrom
behruznassre:fix/forwarder-network-escalation
Open

fix: escalate Claude companion network calls#82
behruznassre wants to merge 1 commit into
sendbird:mainfrom
behruznassre:fix/forwarder-network-escalation

Conversation

@behruznassre

Copy link
Copy Markdown
Contributor

Summary

  • require targeted require_escalated sandbox permissions whenever Codex launches the Claude companion
  • cover foreground and background review/adversarial-review paths plus rescue forwarding
  • add contract and Codex E2E assertions so these launch instructions cannot silently regress

Root cause

Codex's default workspace-write sandbox does not provide network access. The built-in forwarding paths launched claude-companion.mjs without requesting targeted escalation, so the Claude CLI could start but DNS resolution for the Claude API failed with ENOTFOUND.

The fix escalates only the companion shell call, with a narrowly scoped justification. It does not enable network access globally; Claude's own task/review sandbox and permission controls continue to govern repository access and mutations.

Validation

  • test-first contract check failed in the three affected skill/runtime contracts before the implementation change
  • node --test tests/skills-contracts.test.mjs: 9 passed, 0 failed
  • real companion API smoke test under targeted escalation returned exactly CC_NETWORK_OK
  • npm run check:
    • unit: 505 passed, 0 failed
    • integration: 41 passed, 0 failed
    • Codex E2E: 22 passed, 0 failed
  • git diff --check: clean

Closes #81

Require targeted sandbox escalation when Codex launches the Claude companion so API DNS access is available without enabling network access globally. Add contract and end-to-end coverage for rescue, review, and adversarial review paths.\n\nRefs sendbird#81
@upwind-code-us

Copy link
Copy Markdown

Upwind Upwind IaC Scan - 🔍 Scan in progress…

Upwind is scanning this PR. Results will appear here when the scan completes.

@upwind-code-us

Copy link
Copy Markdown

Upwind Upwind Code Scan - 🔍 Scan in progress…

Upwind is scanning this PR. Results will appear here when the scan completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in forwarders run Claude without network escalation

1 participant