fix: preserve sandboxed background jobs on EPERM#80
Open
behruznassre wants to merge 1 commit into
Open
Conversation
Treat permission-denied zero-signal probes as evidence that a process exists so the stale-job reaper does not fail live Claude jobs. Add deterministic EPERM and ESRCH coverage.\n\nRefs sendbird#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EPERMESRCHand other probe failures classified as not aliveRoot cause
isProcessAlive()treated everyprocess.kill(pid, 0)exception as proof that the process was dead. On macOS Codex sessions, sandbox policy can returnEPERMfor a live background Claude process.reapStaleJobs()then moved the job tofailed; the later successful completion CAS respected that terminal state, leaving the complete review only in the log.The zero-signal probe already sits at the correct shared boundary. This change preserves its current boolean API and recognizes the POSIX distinction:
EPERMmeans the process exists but cannot be signaled, whileESRCHmeans it does not exist.Validation
process.kill(1, 0)returnedEPERM.reapStaleJobs()path with that PID retainedstatus: running,phase: running, and no error.npm run checkCloses #79